Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3610229ybx; Sat, 9 Nov 2019 00:28:27 -0800 (PST) X-Google-Smtp-Source: APXvYqxbjG6xmm9YwXa9Cq343B+Zv479IerHYo7vojjjnLdOKqlBpvX9hX8GO0bLe2ope+Pysl58 X-Received: by 2002:a17:906:1611:: with SMTP id m17mr13302017ejd.281.1573288107506; Sat, 09 Nov 2019 00:28:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573288107; cv=none; d=google.com; s=arc-20160816; b=HFbGv4mcJp+sAZ26ljalSZDDBV1n1XGYWYkf2r5UU4kJRj1PRrVdJxDO5Ji7Xqdm++ uDlMQBL0hT2WfLZmqaC8+YzHk2yXBOQwG7hCyISsNhw8ywADvBNW7x6P7J0CiKk8HdaU pIancyshMdI7piUgEn88CAqYoTLnKEkg7NJ0lab8kmy4W+lLJqIaL2H3J0kjbW4QZz7T ipTvDkMk9+ydTXuSNU3NvJDb4aqUMQ41VMuWD3GQW5Cv2VDEg88q7dbyohwtXnOIEplP 73ZXhbq5A4OWFsdizS3Pmpl2nZao9xE6HoqChPxn1vadjKO7U/MMBrvaU29Nchq1DscQ Th7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=DdIslVEiSg1RYLTRpC8O7sk74S/8YrayhkuIx8Qog9s=; b=oiVT/6ma2T5dqoxAtpMIc1Wd4ZrHu4QcyYO1/HCM/byipaKkPIy1kt+Y+2oXtxZZGP +IA8YO/SD5aimZc4/euAGVlnfIfrpzClEpOPQG6jmYuWhloyhC9xksf8+jikNNwEndUm g0c+Nbdq1vNW8dwAKmFvvvYzI2lbSNS2UuBiiApydigOqnSKU0AiIHFOwFsxWjjsD0mW wzpiC3IewAATntsAJVK6xAPS8EYXCafEyNfmb5rq4hHjZxTHsXMp7nUl+WP40ArLOvfC O4C5tlrvC/TEYVOClV6h+YN4MXKAmQmOYY6CR3oWB/Wza5L5sJA9b9wJ4RaEJJfjSIW8 gRZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12si7148edh.26.2019.11.09.00.27.49; Sat, 09 Nov 2019 00:28:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726219AbfKII05 (ORCPT + 99 others); Sat, 9 Nov 2019 03:26:57 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:5752 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726136AbfKII04 (ORCPT ); Sat, 9 Nov 2019 03:26:56 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 32D67157DA822E96A5FA; Sat, 9 Nov 2019 16:26:53 +0800 (CST) Received: from [127.0.0.1] (10.184.12.158) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Sat, 9 Nov 2019 16:26:43 +0800 Subject: Re: [PATCH v2 01/11] irqchip/gic-v3-its: Free collection mapping on device teardown To: Marc Zyngier , CC: Thomas Gleixner , Jason Cooper , , , Heyi Guo References: <20191108165805.3071-1-maz@kernel.org> <20191108165805.3071-2-maz@kernel.org> From: Zenghui Yu Message-ID: <68a30908-90ea-7aeb-0ef2-6197ef8805e3@huawei.com> Date: Sat, 9 Nov 2019 16:26:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Thunderbird/64.0 MIME-Version: 1.0 In-Reply-To: <20191108165805.3071-2-maz@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.184.12.158] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/11/9 0:57, Marc Zyngier wrote: > We allocate the collection mapping on device creation, but somehow > free it on the irqdomain free path, which is pretty inconsistent > and has led to bugs in the past. > > Move it to the point where we teardown the device, making the > alloc/free symetric. > > Signed-off-by: Marc Zyngier Reviewed-by: Zenghui Yu