Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3699712ybx; Sat, 9 Nov 2019 02:15:07 -0800 (PST) X-Google-Smtp-Source: APXvYqzRAgXl/2afiZkgsGqdr3z9Dc8AkbgWmqz7f9DcHIRmbD14LLcPKHgGubyjmFplOU3hIZ7I X-Received: by 2002:aa7:c493:: with SMTP id m19mr15433345edq.39.1573294507627; Sat, 09 Nov 2019 02:15:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573294507; cv=none; d=google.com; s=arc-20160816; b=0E48EOppB9HWbcLqw7ugLMl/IuV6ECIRDa0jAL67CNqoGuPO5a7PGCJxqJV4jz7FDp d2BPGEMPm6CAL2upGsoDmtMP0BH/vrVag8MK3Itkee+PFxsPw/EYlP7ghKahNZoIAx2l G2t94/kpBzSeOSzGU/3sOH9lISPyXfqQ4da+BCjloZCXiGHGrTljTShaelTtcYm6Byno vz65n+jsx76j23NP7DQoTp7jNEtT1U5w9WVdBFvDUOLWeCJY0e5ZNVPsGSPD3vT/Tpdr TY4SM7U/iw56KHa4oQ2WjncAukMO6v8A0lHYWrsKZUXv6GRKVdxlHe16kSvGOLKtlve5 cIlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CEeCWf0z3WtnIkSC44XBMnqQMurafw1H0plYSfhYdq8=; b=ipqumpoh8yDYC6qoG6WVBfuo4SXSQPk8uSrUmImaYcieeqHVYay4q1mgk9Ka+uqikH aMRuPrHgYYNk8N9dhXXmutP9wzU0ztg7WFhD1kf62t34kuU9Cm4fJrkMhXfLnS4hqwZX zyKBVOFHqGEHk3gBGpfCAzjPOHIJEFh+28WHrOMfDKLGLJx0eWNH2I0Jp29tIFkE8Nlh ptdEO1uOLz7Nkyb6MCnJooqv/+oQwpMIA3RkipZVSHw535hDEVYmjvQzhYdwBrSCL0bp K4S6gdluouaK/HI8CNx5/o4sBp0DnrSB0cog9msK7eiQ0rKkDoruyHayqb5GU1Ur/otE IGPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=L5gnkNur; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m12si1290154ejr.306.2019.11.09.02.14.44; Sat, 09 Nov 2019 02:15:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=L5gnkNur; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726426AbfKIKLw (ORCPT + 99 others); Sat, 9 Nov 2019 05:11:52 -0500 Received: from mail.skyhub.de ([5.9.137.197]:45458 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbfKIKLv (ORCPT ); Sat, 9 Nov 2019 05:11:51 -0500 Received: from zn.tnic (p200300EC2F1EA7009D7000FE00A4E362.dip0.t-ipconnect.de [IPv6:2003:ec:2f1e:a700:9d70:fe:a4:e362]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4B4651EC0CF8; Sat, 9 Nov 2019 11:11:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1573294310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=CEeCWf0z3WtnIkSC44XBMnqQMurafw1H0plYSfhYdq8=; b=L5gnkNurZg5cHgNIseSlKsSAylSnAu1CiZd/KSyUyrKZF7HsISpeP8mukqZUbLaJjlwHxW 8FwX8tgU5+DxxpqchFAjdNUwgZlkd0/wivPMEi13wzS8Gf1Fe7jp6I3e9/sFlnLMhHo3Zb 2OGHLAcLqFnSia9sYa51PtDP8bPjSlY= Date: Sat, 9 Nov 2019 11:11:46 +0100 From: Borislav Petkov To: Robert Richter Cc: Mauro Carvalho Chehab , Tony Luck , James Morse , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Joe Perches Subject: Re: [PATCH v2 05/20] EDAC, mc: Remove needless zero string termination Message-ID: <20191109101146.GB2699@zn.tnic> References: <20191106093239.25517-1-rrichter@marvell.com> <20191106093239.25517-6-rrichter@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191106093239.25517-6-rrichter@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2019 at 09:33:11AM +0000, Robert Richter wrote: > Since this is a string already and strlen() has been used to advance > the pointer, the end of the buffer is already zero terminated. Remove > the needless zero string termination. Changed that to: "The e string to which this is pointing to has already been cleared earlier in the function so remove the needless zero string termination." -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette