Date: Thu, 12 Jan 2006 16:11:06 -0600
From: Jon Mason <jdmason@us.ibm.com>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Adrian Bunk <bunk@stusta.de>, Muli Ben-Yehuda <mulix@mulix.org>,
       Jiri Slaby <slaby@liberouter.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Prevent trident driver from grabbing pcnet32 hardware
Message-ID: <20060112221106.GH17539@us.ibm.com>
References: <20060112175051.GA17539@us.ibm.com> <43C6ADDE.5060904@liberouter.org> <20060112200735.GD5399@granada.merseine.nu> <1137100539.2370.68.camel@mindpipe> <20060112215853.GW29663@stusta.de> <1137103614.2370.75.camel@mindpipe>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1137103614.2370.75.camel@mindpipe>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1629
Lines: 37

On Thu, Jan 12, 2006 at 05:06:53PM -0500, Lee Revell wrote:
> On Thu, 2006-01-12 at 22:58 +0100, Adrian Bunk wrote:
> > On Thu, Jan 12, 2006 at 04:15:38PM -0500, Lee Revell wrote:
> > > On Thu, 2006-01-12 at 22:07 +0200, Muli Ben-Yehuda wrote:
> > > > On Thu, Jan 12, 2006 at 08:28:30PM +0100, Jiri Slaby wrote:
> > > > 
> > > > > You should change alsa driver (sound/pci/trident/trident.c), rather than this,
> > > > > which will be removed soon, I guess. And, additionally, could you change that
> > > > > lines to use PCI_DEVICE macro?
> > > > 
> > > > This driver is not up for removal soon, as it supports a device that
> > > > the alsa driver apparently doesn't (the INTERG_5050).
> > > 
> > > When were you going to report this?
> > 
> > I already reported this as ALSA bug #1293.
> > 
> > The problem is the lack of a tester, and I'm currently inclined to 
> > schedule this driver for removal although this PCI ID is still missing - 
> > either noone is using these settop boxes anymore or someone will 
> > volunteer to test patches.
> 
> Hmm, yeah, if the hardware was only used in set top boxes there's not a
> lot that can be done, unless someone wants to donate one to the ALSA
> project.
> 
> It might be as simple as adding the PCI IDs to the driver.

I agree, add the IDs to the ALSA driver and if someone using a
INTERG_5050 adapter has problems....instant tester.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/