Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4152161ybx; Sat, 9 Nov 2019 10:06:30 -0800 (PST) X-Google-Smtp-Source: APXvYqw9vjF/7DEukRubdKKNapglDfL1Imv2nM3YIctIhVtG0V8IWG076nuNdxX03eziNzp0E1TC X-Received: by 2002:a17:906:3458:: with SMTP id d24mr14956258ejb.271.1573322789997; Sat, 09 Nov 2019 10:06:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573322789; cv=none; d=google.com; s=arc-20160816; b=lOzHOdb17pBcvnGENceAX0DODB6d78PxUkTBAQferp8RUIEVoxuTueJ0Cyd0OGgAfd ND98YFSjOnOMdVjRG+B3HQCgq/yCkBlu6q9zrxbqnAHJb//WTaJNQFYNUwGhqOEpCm2u lvJjNpmBNC456/FZOsHd5yf9KT7GXl3cCIyqLhrgONjA8/VdoFLx3Dutils1lnI1GaEg Gy+XthTt9iEnUt1b7yFDpdPaWC+CA/Y6RGFK7MFpJXPV5WuCGWqszgwO/0w0KWDC5yFF XdYJAwJQ65dboagK7XMz9N+n67ov/ETT685H4dQ5ec3LTGgnqJSxeu+NpjdqYKRfbO7K 1qFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cqeORfAJE3XJDG3ERMa2FWK8uUkd20irvFAJgrg2M6s=; b=s4EiNjqC42r0+VUilIGfax66kMEP/7airDro3iOf1DLbKrKrlYuVTK6Njti6934qWZ 07aH5U5/DvhXHis3KO6TP7gbFR4sp5lg5pla4vpcmUq8Cw0cPHXeLYTrEMecPkcCRE6o q6KvyuGC4lNumMaRNB/44r9dY/hm78UVigSE5XHBnW0SJYo0mzRnexldpOoOa1e7h/ka KHJ/HTpraJP7bta4HRj4BigDR0NFAz8yD5iJGg2EW1MJwM0WnNN5j2CzlsRVuUym5PFk ujW+scPHa5PrTIDlbbz2yifS5wjJCk2I3w2fPExUhY4MdWMZo4RmvrIIRLAMHaLwJQaM zhIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gq14si913905ejb.190.2019.11.09.10.06.06; Sat, 09 Nov 2019 10:06:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726758AbfKISCe (ORCPT + 99 others); Sat, 9 Nov 2019 13:02:34 -0500 Received: from orthanc.universe-factory.net ([104.238.176.138]:54934 "EHLO orthanc.universe-factory.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbfKISCc (ORCPT ); Sat, 9 Nov 2019 13:02:32 -0500 Received: from localhost.localdomain (unknown [185.216.33.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by orthanc.universe-factory.net (Postfix) with ESMTPSA id A21D01F56E; Sat, 9 Nov 2019 18:54:38 +0100 (CET) From: Matthias Schiffer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, Matthias Schiffer Subject: [PATCH net-next 2/2] bridge: implement get_link_ksettings ethtool method Date: Sat, 9 Nov 2019 18:54:14 +0100 Message-Id: <8e414e98928aba7f11ea997498fb18af05434f5f.1573321597.git.mschiffer@universe-factory.net> X-Mailer: git-send-email 2.24.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We return the maximum speed of all active ports. This matches how the link speed would give an upper limit for traffic to/from any single peer if the bridge were replaced with a hardware switch. Signed-off-by: Matthias Schiffer --- net/bridge/br_device.c | 37 +++++++++++++++++++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index e804a3016902..e8a2d0c13592 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -263,6 +263,38 @@ static void br_getinfo(struct net_device *dev, struct ethtool_drvinfo *info) strlcpy(info->bus_info, "N/A", sizeof(info->bus_info)); } +static int br_get_link_ksettings(struct net_device *dev, + struct ethtool_link_ksettings *cmd) +{ + struct net_bridge *br = netdev_priv(dev); + struct net_bridge_port *p; + + cmd->base.duplex = DUPLEX_UNKNOWN; + cmd->base.port = PORT_OTHER; + cmd->base.speed = SPEED_UNKNOWN; + + list_for_each_entry(p, &br->port_list, list) { + struct ethtool_link_ksettings ecmd; + struct net_device *pdev = p->dev; + + if (!netif_running(pdev) || !netif_oper_up(pdev)) + continue; + + if (__ethtool_get_link_ksettings(pdev, &ecmd)) + continue; + + if (ecmd.base.speed == (__u32)SPEED_UNKNOWN) + continue; + + if (cmd->base.speed == (__u32)SPEED_UNKNOWN || + cmd->base.speed < ecmd.base.speed) { + cmd->base.speed = ecmd.base.speed; + } + } + + return 0; +} + static netdev_features_t br_fix_features(struct net_device *dev, netdev_features_t features) { @@ -365,8 +397,9 @@ static int br_del_slave(struct net_device *dev, struct net_device *slave_dev) } static const struct ethtool_ops br_ethtool_ops = { - .get_drvinfo = br_getinfo, - .get_link = ethtool_op_get_link, + .get_drvinfo = br_getinfo, + .get_link = ethtool_op_get_link, + .get_link_ksettings = br_get_link_ksettings, }; static const struct net_device_ops br_netdev_ops = { -- 2.24.0