Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4217006ybx; Sat, 9 Nov 2019 11:18:50 -0800 (PST) X-Google-Smtp-Source: APXvYqyzpAv9cQc1zHqdB0qHKOQoG7qgpdQ+gQtfqxCkUbmD7xMo23/DP8NBgwW/ePokB27Dgop1 X-Received: by 2002:a17:906:8697:: with SMTP id g23mr15395626ejx.177.1573327130259; Sat, 09 Nov 2019 11:18:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573327130; cv=none; d=google.com; s=arc-20160816; b=l5XBBACH6Vugg4uoVeHOXZ/cAvKvkF3YPHPnS8ztaiUOfUVtAqrRRHyszM1FEDvAyr mffFohtykIk9YmOjNd/yPOLJtIHhY8bWxDwzIH1q6JR9rtpKFssLETuuw20ihxoXp8JG Nl3XtjR56Ou3QxzEjfzNH537i+D1wn/z/gufgHYZSzB7BAs26KDlOM7uxUswWON9eKeP b0oa4sWWNrvOlz6UWQJ8osGCNMSZapVTPC86IW3BDzxezdpwFHxRnbSbZWkJSeDRRGWK wtE65GoVIdlwqRgvzu7Kh+R4G/ZTZyeAiFD83TgDUm4aBfPkLJ+sU7+LpLLeFoD9gDpa PQ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TMGL0/JOFpPqKkGlrsxqclkHeaNLkWbgoH9TNGWPKSw=; b=V9wd9nwMxapKtbzmi5H3vpMubm/Z8kiXSSt08YpYCmHNiPflcjaB70+Eqr+YEbiZjz +a6cAwXmpsmSkvwI+ReeoDNTIl/VY0iL902M3tPrBU6KV+lFuhGeVgE5bN3nDM19tR4D a5XUa6NVukAzbF+jf10yLg7CNci93NNSqaZBxON/fnEQXUQDtiLcQUHFg5Ld9GcVV0EJ ZyJQeeYgm3ShcW/618lIEognTxVBYtlaeRhFpErnaxEigFkDHVByzf3lHWuYwM2gXKpv +gxhG8/ln88Nu31aQUmdz93NDbFUFN92SCc5Gofk0+uMro7RZVRb4lFEw/uYLYkUSOTG HjHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lkiCeald; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i7si6953276eda.375.2019.11.09.11.18.27; Sat, 09 Nov 2019 11:18:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lkiCeald; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726651AbfKITRw (ORCPT + 99 others); Sat, 9 Nov 2019 14:17:52 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:33453 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbfKITRu (ORCPT ); Sat, 9 Nov 2019 14:17:50 -0500 Received: by mail-pg1-f196.google.com with SMTP id h27so6354347pgn.0 for ; Sat, 09 Nov 2019 11:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TMGL0/JOFpPqKkGlrsxqclkHeaNLkWbgoH9TNGWPKSw=; b=lkiCealdzclaVAPsevr74tOpi5JiABXIsPgU1ZVyWip88uN0+FOgeLeKvj1vc4lJJ9 FT0x0EoErJL5QQFJC5uWygVLO7Sex5+OJk+TbBSgzROcaOM9R/NSkTexwy+x9ekor8mP egLHNr2ujeun+0/0VYIG8MRz1J0x379phIBME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TMGL0/JOFpPqKkGlrsxqclkHeaNLkWbgoH9TNGWPKSw=; b=ryvoT5Yh6takVu7lHBHGHddgWeoQjnQHU+Hnr5lc2G3vvmTFNowPSpnfJWALHuXP4e kBKs3UM+z+12ikIrHks9Yg9WZdoAnEnIhmdHR8DJHawc6Iqjl0vM9DMEIOV7U+Pnc6dM ZEJhdh1Ba41R++6ZI6TCkRxCbBK45TpCgTLoPzdo0XNzRLsiKHfCW0/kSrebk3IHRh9e rGRwDo5BWdWsIF85P2pmvNYlFDsJuTOtAGCzx0cP+GwntSDTqvotxhjbujlvfQJii7ah VjbqfUPrFGvkMF/CuMMnkj3rd8RGfHPAgKPb6i4yAZv6m+0MHJlQ4R4mzrCnW95SkFkm i1Xg== X-Gm-Message-State: APjAAAXm97TeaajbI7cvaZVbMjO5i6Uf53z6M6AXrEGMJ7Oy4L3Rrior g7IgH9+PCkyWru91wt4nSosCJg== X-Received: by 2002:a63:e84d:: with SMTP id a13mr19382177pgk.226.1573327069085; Sat, 09 Nov 2019 11:17:49 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id i11sm9193577pgd.7.2019.11.09.11.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Nov 2019 11:17:48 -0800 (PST) From: Douglas Anderson To: Paul Burton , Jason Wessel , Daniel Thompson Cc: qiaochong@loongson.cn, kgdb-bugreport@lists.sourceforge.net, ralf@linux-mips.org, Douglas Anderson , Sebastian Andrzej Siewior , James Hogan , Mike Rapoport , "Eric W. Biederman" , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Serge Semin , Andrew Morton Subject: [PATCH 1/5] MIPS: kdb: Remove old workaround for backtracing on other CPUs Date: Sat, 9 Nov 2019 11:16:40 -0800 Message-Id: <20191109111623.1.I30a0cac4d9880040c8d41495bd9a567fe3e24989@changeid> X-Mailer: git-send-email 2.24.0.432.g9d3f5f5b63-goog In-Reply-To: <20191109191644.191766-1-dianders@chromium.org> References: <20191109191644.191766-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As of commit 2277b492582d ("kdb: Fix stack crawling on 'running' CPUs that aren't the master") we no longer need any special case for doing stack dumps on CPUs that are not the kdb master. Let's remove. Signed-off-by: Douglas Anderson --- I have no way to test this personally, so hopefully someone who uses kdb/kgdb on MIPS can. Ideally this patch should be Acked by MIPS folks and then land through the kdb/kgdb tree since the next patch in the series, ("kdb: kdb_current_regs should be private") depends on it. arch/mips/kernel/traps.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c index 342e41de9d64..46fbcfeaae9a 100644 --- a/arch/mips/kernel/traps.c +++ b/arch/mips/kernel/traps.c @@ -210,11 +210,6 @@ void show_stack(struct task_struct *task, unsigned long *sp) regs.regs[29] = task->thread.reg29; regs.regs[31] = 0; regs.cp0_epc = task->thread.reg31; -#ifdef CONFIG_KGDB_KDB - } else if (atomic_read(&kgdb_active) != -1 && - kdb_current_regs) { - memcpy(®s, kdb_current_regs, sizeof(regs)); -#endif /* CONFIG_KGDB_KDB */ } else { prepare_frametrace(®s); } -- 2.24.0.432.g9d3f5f5b63-goog