Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 08 Nov 2019 11:35:27 -0800 (PST)
Message-Id: <20191108.113527.2242883926552730503.davem@davemloft.net>
To:     gregkh@linuxfoundation.org
Cc:     jwi@linux.ibm.com, sashal@kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 204/205] s390/qeth: limit csum offload
 erratum to L3 devices
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191108123416.GA732985@kroah.com>
References: <20191108120025.GM4787@sasha-vm>
        <4d8f1938-af6e-7e0e-4085-2f7c53390b2d@linux.ibm.com>
        <20191108123416.GA732985@kroah.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Greg KH <gregkh@linuxfoundation.org>
Date: Fri, 8 Nov 2019 13:34:16 +0100

> On Fri, Nov 08, 2019 at 01:16:26PM +0100, Julian Wiedmann wrote:
>> On 08.11.19 13:00, Sasha Levin wrote:
>> > On Fri, Nov 08, 2019 at 12:50:24PM +0100, Julian Wiedmann wrote:
>> >> On 08.11.19 12:37, Sasha Levin wrote:
>> >>> From: Julian Wiedmann <jwi@linux.ibm.com>
>> >>>
>> >>> [ Upstream commit f231dc9dbd789b0f98a15941e3cebedb4ad72ad5 ]
>> >>>
>> >>> Combined L3+L4 csum offload is only required for some L3 HW. So for
>> >>> L2 devices, don't offload the IP header csum calculation.
>> >>>
>> >>
>> >> NACK, this has no relevance for stable.
>> > 
>> > Sure, I'll drop it.
>> > 
>> > Do you have an idea why the centos and ubuntu folks might have
>> > backported this commit into their kernels?
>> > 
>> 
>> No clue, I trust they have their own reasons.
>> 
> 
> I cant see centos backporting anything unless they were asked to do so.
> And this really looks like a "bugfix" to me, why isn't this relevant for
> any older kernel versions?

Yeah seriously, this looks entirely legit.