Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161370AbWALWUs (ORCPT ); Thu, 12 Jan 2006 17:20:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161374AbWALWUs (ORCPT ); Thu, 12 Jan 2006 17:20:48 -0500 Received: from e4.ny.us.ibm.com ([32.97.182.144]:41117 "EHLO e4.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1161370AbWALWUq (ORCPT ); Thu, 12 Jan 2006 17:20:46 -0500 Date: Thu, 12 Jan 2006 16:20:37 -0600 From: Jon Mason To: Adrian Bunk Cc: Muli Ben-Yehuda , Jiri Slaby , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Prevent trident driver from grabbing pcnet32 hardware Message-ID: <20060112222036.GI17539@us.ibm.com> References: <20060112175051.GA17539@us.ibm.com> <43C6ADDE.5060904@liberouter.org> <20060112200735.GD5399@granada.merseine.nu> <20060112214719.GE17539@us.ibm.com> <20060112220039.GX29663@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060112220039.GX29663@stusta.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1389 Lines: 32 On Thu, Jan 12, 2006 at 11:00:39PM +0100, Adrian Bunk wrote: > On Thu, Jan 12, 2006 at 03:47:19PM -0600, Jon Mason wrote: > > On Thu, Jan 12, 2006 at 10:07:35PM +0200, Muli Ben-Yehuda wrote: > > > On Thu, Jan 12, 2006 at 08:28:30PM +0100, Jiri Slaby wrote: > > > > > > > You should change alsa driver (sound/pci/trident/trident.c), rather than this, > > > > which will be removed soon, I guess. And, additionally, could you change that > > > > lines to use PCI_DEVICE macro? > > > > > > This driver is not up for removal soon, as it supports a device that > > > the alsa driver apparently doesn't (the INTERG_5050). As for > > > PCI_DEVICE, agreed. Jon, feel like patching it up? > > > > Patches to follow. > > > > After looking at the ALSA driver, it doesn't support PCI IDs for > > ALI_5451 or CYBER5050. Someone should look into porting any necessary > > code from sound/oss/trident.c to sound/pci/trident/trident.c > > CYBER5050 is discussed in ALSA bug #1293 (tester wanted). > ALI_5451 is supported by the snd-ali5451 driver. Sorry, I grepped for PCI_DEVICE_ID_ALI_5451 not 0x5451. Sending a patch to fix that up too. Thanks, Jon - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/