Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030381AbWALWac (ORCPT ); Thu, 12 Jan 2006 17:30:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030437AbWALWac (ORCPT ); Thu, 12 Jan 2006 17:30:32 -0500 Received: from smtp.osdl.org ([65.172.181.4]:50096 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1030381AbWALWab (ORCPT ); Thu, 12 Jan 2006 17:30:31 -0500 Date: Thu, 12 Jan 2006 14:30:19 -0800 (PST) From: Linus Torvalds To: Jeff Garzik cc: Andrew Morton , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [git patches] 2.6.x net driver updates In-Reply-To: <20060112221322.GA25470@havoc.gtf.org> Message-ID: References: <20060112221322.GA25470@havoc.gtf.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 39 On Thu, 12 Jan 2006, Jeff Garzik wrote: > > dann frazier: > CONFIG_AIRO needs CONFIG_CRYPTO I think this is done wrong. It should "select CRYPTO" rather than "depends on CRYPTO". Otherwise people won't see it just because they don't have crypto enabled, which is not very user-friendly. Btw, why are these casts there? Either the functions are of the right type, or they aren't. In neither case is the cast correct. I do realize that there are comments in that says that you should do the cast, but that's no excuse for crap or stupid code. If it's an issue of trying to make greppable code, why not have just the comment? > @@ -2378,6 +2566,15 @@ static const iw_handler atmel_handler[] > (iw_handler) atmel_get_encode, /* SIOCGIWENCODE */ > (iw_handler) atmel_set_power, /* SIOCSIWPOWER */ > (iw_handler) atmel_get_power, /* SIOCGIWPOWER */ > + (iw_handler) NULL, /* -- hole -- */ > + (iw_handler) NULL, /* -- hole -- */ ... Hmm? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/