Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4592802ybx; Sat, 9 Nov 2019 20:06:07 -0800 (PST) X-Google-Smtp-Source: APXvYqx0WzNPyMJxpH8NUZXqiqQkRglQjyyjaeXe4cp5qM71sAxLFN2YGKmB8PJXenoliVBDn8lP X-Received: by 2002:aa7:c954:: with SMTP id h20mr19267002edt.159.1573358767253; Sat, 09 Nov 2019 20:06:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573358767; cv=none; d=google.com; s=arc-20160816; b=TMPJlUwajHgc8tVYDThkVC5hUQhR17FxQXfFGZJ/414ffD6eTFpjGwSSp3KmbR0G1t DqqwIusOl8cUjPpZvWNVrPdMCND1zaVw1geqG9pjMFIJGTj1bj+H2tEOfcFOXX7Utslx YkM+P5czMgMHRxchulYno+i8SAo7WUHL3DtEMFtdSCPFiUI0pEWLpr1YBjmaX0fKlpIM bp9NxpMPGOb2kSHs2Nn20+GLkO3IfKvmhi/iLnf7Xs3R5FypKu+W3Mvl3nItN1h06QLl m1zaE6UfuSSCrOzibKktS+qjQCHVFJYl7EQGJy5/uxLix86X8WCQnSItIg8hsjnJvvjp bY7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=AGfdvwa/vdYBeHEOJXW4s2CeDZjGvmGwsxrI4QcSN0g=; b=M0bgEqX2qZrSr9yha9jkz4FibfejOVgI0e2GNOQZA/DWb1H39v3cqeDrNdrpV58VXe hA81w9W+wEPyi7ud6inlBie+y5vNvcmfLMQqY31mYV3+ToJJLperYog8zRfnILhjkGVy YSDaljz6MvpBk0rmwkps/qzcZvBbQNtAAjTZPzn3r1DPw2hZeO+YqNPzHAdkBY3HUvk0 fI6ho4zW9qJ5/2rC0Bq6JoZo08hWDsjwxUwcgfIdHTUfL2IS1AX5zBgYA/yCV45XbDAQ NpejHbrVTYdJcn++cb8mC82TvDX3NxrjfyP/7uvDazbcjJdYdxzi0goi2IVhXL9PWe5l biYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p30si8351102eda.205.2019.11.09.20.05.06; Sat, 09 Nov 2019 20:06:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726663AbfKJD4f (ORCPT + 99 others); Sat, 9 Nov 2019 22:56:35 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:35790 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726559AbfKJD4f (ORCPT ); Sat, 9 Nov 2019 22:56:35 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 21A8D153A9CAF; Sat, 9 Nov 2019 19:56:34 -0800 (PST) Date: Sat, 09 Nov 2019 19:56:33 -0800 (PST) Message-Id: <20191109.195633.2022092668080109840.davem@davemloft.net> To: tonylu@linux.alibaba.com Cc: edumazet@google.com, rostedt@goodmis.org, mingo@redhat.com, laoar.shao@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tcp: remove redundant new line from tcp_event_sk_skb From: David Miller In-Reply-To: <20191109104305.92898-1-tonylu@linux.alibaba.com> References: <20191109104305.92898-1-tonylu@linux.alibaba.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 09 Nov 2019 19:56:34 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tony Lu Date: Sat, 9 Nov 2019 18:43:06 +0800 > This removes '\n' from trace event class tcp_event_sk_skb to avoid > redundant new blank line and make output compact. > > Fixes: af4325ecc24f ("tcp: expose sk_state in tcp_retransmit_skb tracepoint") > Reviewed-by: Eric Dumazet > Reviewed-by: Yafang Shao > Signed-off-by: Tony Lu > --- > v1->v2: > - append Fixes tag Applied and queued up for -stable, thanks.