Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 10 Nov 2019 14:46:06 +0000
From:   Marc Zyngier <maz@misterjones.org>
To:     linux-kernel@vger.kernel.org
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>, lorenzo.pieralisi@arm.com,
        Andrew.Murray@arm.com, yuzenghui@huawei.com,
        Heyi Guo <guoheyi@huawei.com>
Subject: Re: [PATCH v2 07/11] irqchip/gic-v3-its: Add its_vlpi_map helpers
Message-ID: <20191110144606.61a1f537@why>
In-Reply-To: <20191108165805.3071-8-maz@kernel.org>
References: <20191108165805.3071-1-maz@kernel.org>
        <20191108165805.3071-8-maz@kernel.org>
Organization: Metropolis
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri,  8 Nov 2019 16:58:01 +0000
Marc Zyngier <maz@kernel.org> wrote:

> Obtaining the mapping information for a VLPI is something quite common,
> and the GICv4.1 code is going to make even more use of it. Expose it as
> a separate set of helpers.
> 
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
> Link: https://lore.kernel.org/r/20191027144234.8395-8-maz@kernel.org
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 47 ++++++++++++++++++++++----------
>  1 file changed, 32 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 94f13d6b8400..cad8fd18bab7 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -207,6 +207,15 @@ static struct its_collection *dev_event_to_col(struct its_device *its_dev,
>  	return its->collections + its_dev->event_map.col_map[event];
>  }
>  
> +static struct its_vlpi_map *dev_event_to_vlpi_map(struct its_device *its_dev,
> +					       u32 event)
> +{
> +	if (WARN_ON_ONCE(event >= its_dev->event_map.nr_lpis))
> +		return NULL;
> +
> +	return its_dev->event_map.vlpi_maps[event];

As pointed out by our dear friend the 01 bot, the above line lacks a
'&'. It happened to work because this was later reworked, but this
patch on its own breaks the build.

I've now fixed it, and verified that the whole series correctly bisects.

Thanks,

	M.
-- 
Without deviation from the norm, progress is not possible.