Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <10494959.bKODIZ00nm@kreacher> <3269796.AzLOQfDnpo@kreacher>
 <CAJZ5v0jM3+qMvO6dx=FmK-xF0q3YKOwBf-yUPXSBfRjxJ59Cpg@mail.gmail.com>
 <000701d59610$e0b3caa0$a21b5fe0$@net> <CAJZ5v0gsK0OmqAvw2BVGvajPmCTrRGFVVZ0+Y99ZkbbUcWYGOg@mail.gmail.com>
 <000a01d59656$99798710$cc6c9530$@net>
In-Reply-To: <000a01d59656$99798710$cc6c9530$@net>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Sun, 10 Nov 2019 17:48:21 +0100
Message-ID: <CAJZ5v0gZDJ2=PiiGw2mcCcVKBM2OyM1G9nRvJ+iWLFUQcXqZuw@mail.gmail.com>
Subject: Re: [PATCH v2] cpuidle: Use nanoseconds as the unit of time
To:     Doug Smythies <dsmythies@telus.net>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 8, 2019 at 6:04 PM Doug Smythies <dsmythies@telus.net> wrote:
>
> On 2019.11.08 01:45 Rafael J. Wysocki wrote:
> > On Fri, Nov 8, 2019 at 9:45 AM Doug Smythies <dsmythies@telus.net> wrote:
> >
> ...
> >> I have been running this v2 today, with both menu and teo
> >> governors. Acquiring some baseline reference data to compare
> >> to now. The menu governor response seems different (Supporting
> >> information/graphs will come later).
> >
> > That may be good or bad, depending in what way it is different. :-)
>
> My thinking was that the differences should be minimal between
> the baseline (linux-next as of 2019.11.07) and plus your two patches.
> Because this was a change of units, but not functionality.
> Such is the case with the teo governor, but not the menu governor.
> I have not tried the ladder or haltpoll governors, and don't intend to.
>
> Now to attempt to isolate the issue in the code, which might take
> considerable time.

Thanks!

It looks like I have overlooked a unit conversion in menu or done a
unit conversion twice somewhere.