Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp5875797ybx; Sun, 10 Nov 2019 23:37:09 -0800 (PST) X-Google-Smtp-Source: APXvYqyCsC3fhxhUJw+8UuHezVM9ybTn+JrXSdyes9o6781fzwmeGLw9iTiSyqU5wUBo7kfgy5dp X-Received: by 2002:a50:cd53:: with SMTP id d19mr24598263edj.197.1573457829362; Sun, 10 Nov 2019 23:37:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573457829; cv=none; d=google.com; s=arc-20160816; b=mCgc/k/1c0iUcKW2oHFx7x2iqBiEsXjhWLNrBRK9EZOAT8PRCh9ck07bhWhWOK9LKn k8qqGci6vzLAoAn9LDL4iBl8KaIjzKr4DpG11dEmc6suhEIl55aW2ayq8roaAI0O1q+9 drAeXq4/o3+Z/B+Za4C64FY9BIqSc9YAZyfrjDcu/74qGpI7Rc3SIqkMWVeEE4Kmpj4k pinQcvHaVFHFa6AJMSL7x7d2cSl5rJgBrFjX4SapNqCg0YZ/oq15s52htjRsKby8TR5o BiwU/qQMaQr2sV/6aqwIxVxWGm2QCgKQoy4zEAXvNmR6N4LN4Y6nslUop0c8fEAxrjr2 RgIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=11XyuX75h6wLXlM8eIF2c6GY+p1TuOaj5FL64Q+XyMA=; b=YqQt44mJuE9Z1N8ZusL92PgzrPqEbSXcZ1AYfl24Dd55NGWWUkupGee2JIkg/t3Pir M7xaLLW4GbX+yRILGkg3//wdhqkDGjx+PFd3eoL3OBmD6eCPEjUx21wRnvOCBjaJBUq/ lbK/v0G+dLfa5CwwxAyPxzU84dqFHkHPlcFbZHcJsbHp0Q1toyh+yHtkngGn43WZkO4G Wl3nYMPEfNNcGU2v5t/TUXmWyKSIeMepzc7zKmD6MTQnOslDXIRLMrsCfyGqUXT0RcIS 7DabGuuieTyus6esuht7LfYALFxdDeii882Sxz8eaZI723ll69NcAvt5Jv4J02Vi1e+i 0EkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=QIoixCtM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fy15si8597134ejb.432.2019.11.10.23.36.46; Sun, 10 Nov 2019 23:37:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=QIoixCtM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726823AbfKKHd5 (ORCPT + 99 others); Mon, 11 Nov 2019 02:33:57 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:45438 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726652AbfKKHd5 (ORCPT ); Mon, 11 Nov 2019 02:33:57 -0500 Received: by mail-lf1-f66.google.com with SMTP id v8so9004857lfa.12 for ; Sun, 10 Nov 2019 23:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=11XyuX75h6wLXlM8eIF2c6GY+p1TuOaj5FL64Q+XyMA=; b=QIoixCtMLQtH5ivP/i+BLVDDT85cUSsT96NwuYXO3sqDavMb8qbqaQ1rEt/1rhsQA7 9bKf54a4NzkBgFwDRc6SljVSQAg1BpYhc8pdaWjO7e6h4+yXUcxfj4fCMA6hFTn/pwYL UTkRBuhH71NZcBtzr9R67ULNVOR+UkkeOxlpA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=11XyuX75h6wLXlM8eIF2c6GY+p1TuOaj5FL64Q+XyMA=; b=ZewmN01XooC6ZYwg+1+qPl47+hz9Og6pKalXLvI9tZG+/7aq3VRPxfu25abijzNgK8 /8J1Kp+rfEyZswvxEaHolg32xxh+Xmd58zflPChH+vP7ub6X+HWItolXLM2H9GGuEgbu lw2Zi/7h2fd4GpmY9PF0yMvxQQqJv6tpHF8RpghLxPq8ZAjw+2xXqSildLRZSjYazVOy +zDP/MQw1JyqI+bcn4yK1M71h3wBuUQ0C4M4vaFjsWlrdqicP7PzXxvQ8CBpfo/n1TXn x8XLDns7ki4f3Du/fgn+0F7l5UaDU6De274ZfusYnhihfa4E/P9s3TSKtWxCStEeH41q jzrg== X-Gm-Message-State: APjAAAWOPvOtbAaLY8gA6zRwE5y91NNAdOj8avTnas/3pW1qPSxxm/H4 w3nZpfXMoj01pxCIowN49kzgnQ== X-Received: by 2002:a19:855:: with SMTP id 82mr14378120lfi.44.1573457634762; Sun, 10 Nov 2019 23:33:54 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id z127sm5941129lfa.19.2019.11.10.23.33.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Nov 2019 23:33:54 -0800 (PST) Subject: Re: [PATCH v4 47/47] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE To: Li Yang Cc: Qiang Zhao , Christophe Leroy , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , lkml , Scott Wood References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-48-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <14894529-a6bd-9b7e-eacc-06d5e49cc8e8@rasmusvillemoes.dk> Date: Mon, 11 Nov 2019 08:33:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2019 00.48, Li Yang wrote: > On Fri, Nov 8, 2019 at 7:05 AM Rasmus Villemoes > wrote: >> >> There are also ARM and ARM64 based SOCs with a QUICC Engine, and the >> core QE code as well as net/wan/fsl_ucc_hdlc and tty/serial/ucc_uart >> has now been modified to not rely on ppcisms. >> >> So extend the architectures that can select QUICC_ENGINE, and add the >> rather modest requirements of OF && HAS_IOMEM. >> >> The core code as well as the ucc_uart driver has been tested on an >> LS1021A (arm), and it has also been tested that the QE code still >> works on an mpc8309 (ppc). >> >> Signed-off-by: Rasmus Villemoes >> --- >> drivers/soc/fsl/qe/Kconfig | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig >> index cfa4b2939992..f1974f811572 100644 >> --- a/drivers/soc/fsl/qe/Kconfig >> +++ b/drivers/soc/fsl/qe/Kconfig >> @@ -5,7 +5,8 @@ >> >> config QUICC_ENGINE >> bool "QUICC Engine (QE) framework support" >> - depends on FSL_SOC && PPC32 >> + depends on OF && HAS_IOMEM >> + depends on PPC32 || ARM || ARM64 || COMPILE_TEST > > Can you also add PPC64? It is also used on some PPC64 platforms > (QorIQ T series). Sure, but if that's the only thing in the whole series, perhaps you could amend it when applying instead of me sending all 47 patches again. Should PPC32 || PPC64 be spelled PPC? Rasmus