Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp5927146ybx; Mon, 11 Nov 2019 00:43:11 -0800 (PST) X-Google-Smtp-Source: APXvYqyOFijyg/Rv4azmP/LDXN9H/rTLOLEVSlUq1pAk99tVh2B4Dskg/+P9SKJgOT+wTqGs6rKf X-Received: by 2002:a17:906:a3cc:: with SMTP id ca12mr5711673ejb.302.1573461791670; Mon, 11 Nov 2019 00:43:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573461791; cv=none; d=google.com; s=arc-20160816; b=H1VWSG+hKURlExWewRGXbX3CmvP8OnNCNiDQLgkNHqeSUs034ryTCVD1ZXZc3kGz3C mj90gh1Y57IKIluOMWTQUWFVm5QpIZUeEAeDwEFraHKl46tCV2428UBGAw8D+ITQEbU+ 9j5oCWusgCdbu6XYoJe0Pyz07n8f+mRgsoiNqHFTB1rEfXKbHp6alwmbomHX6xc349aD Q67AscAgvrJkeKtMY+UwvSeDOZnqr2QzmCSH2l/OXuD+cXx3t1nj8U0vodtBsI5krkHP 16moOWG2xhQ+fhhCrZ+p7Nwjaz6M1mZiWDxcR40fwfcZZQjO3nCFtOSZ58VDB9xbHgkn WZCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=D9ANwiExHt1yTMKRwFIcJkkf6Wu2KVUdWv6iFNiEGAA=; b=Ytvma+6EhyeqaoVcjkXPPV7qwYM4TckAvt0EFhMnp3Fe+B7N0u7Qpf03ar0xG27HoI f1cVssRvFqFPON5EesIq1U7vmi1u2Z+Fl0rv1R53fN8wUAQkqG/soaJRA1a0Ga6xQWph 864xhJQ34f5AjxiiAhMkj+c8aw9VmahpZ9QKDwPnl9oxwqoQlXkshp9w3OY56DI1cJbQ iFryaptiTmKdyZSb/7oPb20MoVNJRL1aKCempzhMnYuvZigQwAk7W1qdTwuB/OYXg33P zN77CLJktAOsj86qHv4zkj+GodTtjQF3d1uj9rgK/K57KIJukKubULl52HZIIVj9kWxQ pGhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DAu2HnwL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id nf6si8957872ejb.406.2019.11.11.00.42.48; Mon, 11 Nov 2019 00:43:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DAu2HnwL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbfKKIlY (ORCPT + 99 others); Mon, 11 Nov 2019 03:41:24 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:53982 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726791AbfKKIlX (ORCPT ); Mon, 11 Nov 2019 03:41:23 -0500 Received: by mail-wm1-f67.google.com with SMTP id u18so4683667wmc.3 for ; Mon, 11 Nov 2019 00:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=D9ANwiExHt1yTMKRwFIcJkkf6Wu2KVUdWv6iFNiEGAA=; b=DAu2HnwLPOnhy8v0K0GB+6pFXgIA76ujbDLaAKDLnUy+UOcn0kdZAfgLyeJV7aBYOO ZtP7Lub1GggntYGQZhKlXdsBVMVyKIw/q6ucqxcxHpvovYVVWWXmXSkCFkl3FVORINxZ 6JwPTGmn4tDFavjLKE8+U2SkwufzzlQUpoDb5aEL3QgxwvSazJ+bOrVeMezRQKaxX0be zsLkAzBnIJHNUVl9a+x+Wc967jUi//D0gxSKGynPgkkRdDXMjV4VzNvDfr1suGIYSsPU qQyEWSXCYFiaravcRo/tvNMGgmp/oHldr0WbE8vsSW3bTWgPB6d2JhJ13Wzcml4gvpEC G4bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=D9ANwiExHt1yTMKRwFIcJkkf6Wu2KVUdWv6iFNiEGAA=; b=uJ2vFqHZU9DXRlw0Gj9TKbN3w/5Mw4BLAjNDX3JTmX2ZME4seqK34Wh5bBuPkv7g0a vtGvOjsvb5eZwbB328CBnzYwxdZ3Mvg5qp7vaCvrORITM2Fbxsl9D21x3Xwk8VpYeym9 hT2NVGcyTJUnXYrKf8qhhqhpgg3icinRJDyjg5wxKXMMZNjouUAZgXlc+Z5wHlGwL1H7 DEQe8FAnykPwfuF8910r+80/MBrF0kUd7O4FTJ/0qw/3ZC6QU4qNoLj15vrxkOwgR8qB LCPWPvBm9pnYmhr7UwaN7EcY9ByRYsI/v6puy21UkQiGjlWQWyyfH60Xxde14TfyaD8M MFsg== X-Gm-Message-State: APjAAAWnDlg+y8tadAGilqsIhcTL9mEYAmPvmDVteHcbQKDA/u0WZo4i ZocHFXV0Ujh1uBig5afbAbIVEw== X-Received: by 2002:a05:600c:3cc:: with SMTP id z12mr20946217wmd.151.1573461682052; Mon, 11 Nov 2019 00:41:22 -0800 (PST) Received: from dell ([95.147.198.88]) by smtp.gmail.com with ESMTPSA id b8sm14298485wrt.39.2019.11.11.00.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 00:41:21 -0800 (PST) Date: Mon, 11 Nov 2019 08:41:14 +0000 From: Lee Jones To: Tuowen Zhao Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, acelan.kao@canonical.com, mcgrof@kernel.org, davem@davemloft.net Subject: Re: [PATCH v5 3/4] mfd: intel-lpss: use devm_ioremap_uc for MMIO Message-ID: <20191111084114.GJ18902@dell> References: <20191016210629.1005086-1-ztuowen@gmail.com> <20191016210629.1005086-4-ztuowen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191016210629.1005086-4-ztuowen@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Oct 2019, Tuowen Zhao wrote: > Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci > in MTRR. This will cause the system to hang during boot. If possible, > this bug could be corrected with a firmware update. > > This patch use devm_ioremap_uc to overwrite/ignore the MTRR settings > by forcing the use of strongly uncachable pages for intel-lpss. > > The BIOS bug is present on Dell XPS 13 7390 2-in-1: > > [ 0.001734] 5 base 4000000000 mask 6000000000 write-combining > > 4000000000-7fffffffff : PCI Bus 0000:00 > 4000000000-400fffffff : 0000:00:02.0 (i915) > 4010000000-4010000fff : 0000:00:15.0 (intel-lpss-pci) > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203485 > Cc: > Tested-by: AceLan Kao > Signed-off-by: Tuowen Zhao > Acked-by: Mika Westerberg > Acked-by: Andy Shevchenko > Acked-for-MFD-by: Lee Jones > --- > drivers/mfd/intel-lpss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog