Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Nov 2019 14:30:57 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc:     robh+dt@kernel.org, nm@ti.com, ssantosh@kernel.org,
        dan.j.williams@intel.com, dmaengine@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, grygorii.strashko@ti.com,
        lokeshvutla@ti.com, t-kristo@ti.com, tony@atomide.com,
        j-keerthy@ti.com
Subject: Re: [PATCH v4 09/15] dmaengine: ti: New driver for K3 UDMA -
 split#1: defines, structs, io func
Message-ID: <20191111090057.GT952516@vkoul-mobl>
References: <20191101084135.14811-1-peter.ujfalusi@ti.com>
 <20191101084135.14811-10-peter.ujfalusi@ti.com>
 <20191111052828.GN952516@vkoul-mobl>
 <00777586-a3ac-2404-5226-e8c887936a32@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00777586-a3ac-2404-5226-e8c887936a32@ti.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11-11-19, 10:33, Peter Ujfalusi wrote:
> On 11/11/2019 7.28, Vinod Koul wrote:
> > On 01-11-19, 10:41, Peter Ujfalusi wrote:

> >> +	struct udma_static_tr static_tr;
> >> +	char *name;
> >> +
> >> +	struct udma_tchan *tchan;
> >> +	struct udma_rchan *rchan;
> >> +	struct udma_rflow *rflow;
> >> +
> >> +	bool psil_paired;
> >> +
> >> +	int irq_num_ring;
> >> +	int irq_num_udma;
> >> +
> >> +	bool cyclic;
> >> +	bool paused;
> >> +
> >> +	enum udma_chan_state state;
> >> +	struct completion teardown_completed;
> >> +
> >> +	u32 bcnt; /* number of bytes completed since the start of the channel */
> >> +	u32 in_ring_cnt; /* number of descriptors in flight */
> >> +
> >> +	bool pkt_mode; /* TR or packet */
> >> +	bool needs_epib; /* EPIB is needed for the communication or not */
> >> +	u32 psd_size; /* size of Protocol Specific Data */
> >> +	u32 metadata_size; /* (needs_epib ? 16:0) + psd_size */
> >> +	u32 hdesc_size; /* Size of a packet descriptor in packet mode */
> >> +	bool notdpkt; /* Suppress sending TDC packet */
> >> +	int remote_thread_id;
> >> +	u32 src_thread;
> >> +	u32 dst_thread;
> >> +	enum psil_endpoint_type ep_type;
> >> +	bool enable_acc32;
> >> +	bool enable_burst;
> >> +	enum udma_tp_level channel_tpl; /* Channel Throughput Level */
> >> +
> >> +	/* dmapool for packet mode descriptors */
> >> +	bool use_dma_pool;
> >> +	struct dma_pool *hdesc_pool;
> >> +
> >> +	u32 id;
> >> +	enum dma_transfer_direction dir;
> > 
> > why does channel have this, it already exists in descriptor
> 
> The channel can not change role, it is set when it was requested. In the

how do you do this on set? The channel is requested, we do not know the
direction. When prep_ is invoked we know it..

-- 
~Vinod