Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Zavras, Alexios" <alexios.zavras@intel.com>
To:     Joe Perches <joe@perches.com>, Thomas Gleixner <tglx@linutronix.de>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-spdx@vger.kernel.org" <linux-spdx@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: RE: spdxcheck.py complains about the second OR?
Thread-Topic: spdxcheck.py complains about the second OR?
Thread-Index: AQHVkGx97YY5RqhHq0ueYoAqFuykEad7mOCAgAADfoCAAMSpYIAAVI0AgAkKDLA=
Date:   Mon, 11 Nov 2019 09:37:32 +0000
Message-ID: <CY4PR1101MB236097D5F60B4AD344413FCD89740@CY4PR1101MB2360.namprd11.prod.outlook.com>
References: <CAK7LNASwF9y+MkhkvCRATu0qXSJkxx8fZ-DUjQTfWOi9+1YrfQ@mail.gmail.com>
         <alpine.DEB.2.21.1911042310040.17054@nanos.tec.linutronix.de>
         <46615f063c973eee649e3fdb8261978102c89108.camel@perches.com>
         <CY4PR1101MB2360AB7647D9E2FA15044EE4897E0@CY4PR1101MB2360.namprd11.prod.outlook.com>
 <ec20c751ac1e4156aca0b02dfa0cef4b70cb8ec5.camel@perches.com>
In-Reply-To: <ec20c751ac1e4156aca0b02dfa0cef4b70cb8ec5.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-reaction: no-action
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dba886a6-3296-4674-aa78-08d7668ac738
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2019 09:37:32.8844
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vyeTb8uvU2aCmC5NqAsFiuePyH8+md2n8KITCVHK7E6VETjFhFw96qf0zPBglP43WjyI6t1KMB96SkG7viwc6NNnUtfn2ZnaXhYFDFG3Gek=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2120
X-OriginatorOrg: intel.com
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sorry for the delay in replying.
I've never used PLY before, but I do know lex and yacc, so I'm confident th=
at an expression with two (or more) "OR" terms will be handled recursively.

The problem with spdxcheck.py is, I think, that it specifies "nonassoc" in =
the precedence variable, which effectively means that constructs like "a OR=
 b OR c" are not allowed and need to be "(a OR b) OR c". I expect simply de=
leting this string would make everything pass.

The following standalone test code shows that there is no need for any addi=
tional rule in the grammar (the first tests succeed, the last two fail with=
 lexical and parsing errors, respectively):

#!/usr/bin/env python3

import ply.lex as lex
import ply.yacc as yacc

tokens =3D ( 'ID', 'OR', 'AND', 'LPAR', 'RPAR',)

t_ID =3D r'[a-z]+'
t_OR =3D 'OR'
t_AND =3D 'AND'
t_LPAR  =3D r'\('
t_RPAR  =3D r'\)'
t_ignore  =3D ' \t\n'

def p_expr(p):
    '''expr : ID
        | expr AND expr
        | expr OR expr
        | LPAR expr RPAR'''

def t_error(t):
    print("Illegal character '%s'" % t.value[0])
    t.lexer.skip(1)

def p_error(p):
    print("Syntax error in input!", p)


lexer =3D lex.lex()
parser =3D yacc.yacc()

tests =3D ( 'a', 'a OR b', 'a AND b', 'a OR b OR c', 'a OR b AND c OR d',
        'a AND @', 'a OR OR b')
for s in tests:
    print(s)
    parser.parse(s)

#EOF----------------------------------------------------------------

-- zvr

-----Original Message-----
From: Joe Perches <joe@perches.com> =

Sent: Tuesday, 5 November, 2019 16:11
To: Zavras, Alexios <alexios.zavras@intel.com>; Thomas Gleixner <tglx@linut=
ronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; linux-spdx@vger.kernel=
.org; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Masahiro Ya=
mada <yamada.masahiro@socionext.com>
Subject: Re: spdxcheck.py complains about the second OR?

On Tue, 2019-11-05 at 10:11 +0000, Zavras, Alexios wrote:
> This is not correct.
> Since the grammar includes the production "expr: expr OR expr", there =

> is absolutely no need to add a rule with more than two operands -- it =

> will be handled recursively.

You sure about the recursion?

It does work and spdxcheck no longer emits a message for these two files.

> -- zvr
> =

> -----Original Message-----
> From: linux-spdx-owner@vger.kernel.org =

> <linux-spdx-owner@vger.kernel.org> On Behalf Of Joe Perches
> Sent: Monday, 4 November, 2019 23:24
> To: Thomas Gleixner <tglx@linutronix.de>; Masahiro Yamada =

> <yamada.masahiro@socionext.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; =

> linux-spdx@vger.kernel.org; Linux Kernel Mailing List =

> <linux-kernel@vger.kernel.org>
> Subject: Re: spdxcheck.py complains about the second OR?
> =

> On Mon, 2019-11-04 at 23:11 +0100, Thomas Gleixner wrote:
> > On Fri, 1 Nov 2019, Masahiro Yamada wrote:
> > > scripts/spdxcheck.py warns the following two files.
> > > =

> > > $ ./scripts/spdxcheck.py
> > > drivers/net/ethernet/pensando/ionic/ionic_if.h: 1:52 Syntax error: =

> > > OR
> > > drivers/net/ethernet/pensando/ionic/ionic_regs.h: 1:52 Syntax error: =

> > > OR
> > > =

> > > I do not understand what is wrong with them.
> > > =

> > > I think "A OR B OR C" is sane.
> > =

> > Yes it is, but obviously we did not expect files with 3 possible =

> > alternative licenses.
> =

> Perhaps just this, but the generic logic obviously isn't complete.
> ---
>  scripts/spdxcheck.py | 1 +
>  1 file changed, 1 insertion(+)
> =

> diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py index =

> 6374e0..00be34 100755
> --- a/scripts/spdxcheck.py
> +++ b/scripts/spdxcheck.py
> @@ -150,6 +150,7 @@ class id_parser(object):
>                  | ID WITH EXC
>                  | expr AND expr
>                  | expr OR expr
> +                | expr OR expr OR expr
>                  | LPAR expr RPAR'''
>          pass
>  =

> =

> =

> Intel Deutschland GmbH
> Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Christin Eisenschmid, Gary Kershaw Chairperson of =

> the Supervisory Board: Nicole Lau Registered Office: Munich Commercial =

> Register: Amtsgericht Muenchen HRB 186928
> =


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928