Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
To:     Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH] irqchip/ti-sci-inta: Use =?UTF-8?Q?ERR=5FCAST=20inlin?=  =?UTF-8?Q?ed=20function=20instead=20of=20ERR=5FPTR=28PTR=5FERR=28=2E=2E?=  =?UTF-8?Q?=2E=29=29?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 11 Nov 2019 11:24:24 +0109
From:   Marc Zyngier <maz@kernel.org>
Cc:     Markus Elfring <markus.elfring@web.de>,
        <linux-arm-kernel@lists.infradead.org>,
        Jason Cooper <jason@lakedaemon.net>,
        Nishanth Menon <nm@ti.com>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Tero Kristo <t-kristo@ti.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>
In-Reply-To: <670cd9a2-2083-bb5e-7bfc-58d5c90ec756@ti.com>
References: <776b7135-26af-df7d-c3a9-4339f7bf1f15@web.de>
 <670cd9a2-2083-bb5e-7bfc-58d5c90ec756@ti.com>
Message-ID: <29a69991ec7726d133e54a2891159e86@www.loen.fr>
User-Agent: Roundcube Webmail/0.7.2
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019-11-11 04:45, Lokesh Vutla wrote:
> On 05/11/19 5:00 PM, Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Tue, 5 Nov 2019 12:19:39 +0100
>>
>> A coccicheck run provided information like the following.
>>
>> drivers/irqchip/irq-ti-sci-inta.c:250:9-16: WARNING: ERR_CAST can be 
>> used
>> with vint_desc.
>>
>> Generated by: scripts/coccinelle/api/err_cast.cocci
>>
>> Thus adjust the exception handling in one if branch.
>>
>> Fixes: 9f1463b86c13277d0bd88d5ee359577ef40f4da7 
>> ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
>
> Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt 
> Aggregator driver")

I fundamentally disagree with the "Fixes:" tag. This isn't a fix,
just a minor readability improvement. Flagging things as "Fixes:"
ends up triggering all kind of unnecessary backports to -stable.

> With this:
>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

I'll otherwise take this patch in -next.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...