Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191107122115.6244-1-linux@rasmusvillemoes.dk> <ea802f081d1f1d4c5359707ff4553004@www.loen.fr>
In-Reply-To: <ea802f081d1f1d4c5359707ff4553004@www.loen.fr>
From:   Vladimir Oltean <olteanv@gmail.com>
Date:   Mon, 11 Nov 2019 12:31:05 +0200
Message-ID: <CA+h21ho-P3P+ZwVp4uYHYrTzF0V-b+OsBkMKVo3rHC_OV5Y_6Q@mail.gmail.com>
Subject: Re: [PATCH v7 0/2] Add support for Layerscape external interrupt lines
To:     Marc Zyngier <maz@kernel.org>
Cc:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        lkml <linux-kernel@vger.kernel.org>, devicetree@vger.kernel.org,
        Kurt Kanzenbach <kurt@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 11 Nov 2019 at 12:24, Marc Zyngier <maz@kernel.org> wrote:
>
> On 2019-11-07 13:30, Rasmus Villemoes wrote:
> > In v7, I've tried to change from a custom binding to use
> > interrupt-map, modelled on the recent addition of the
> > renesas,rza1-irqc (commits a644ccb819bc and 5e27a314a11f). It's
> > possible that the interrupt-map parsing code can be factored to a
> > common helper, but it's a bit hard to generalize from two examples to
> > know what a good interface would look like.
> >
> > The interrupt-map-mask is a bit arbitrary. 0xff would likely work
> > just
> > as well (but I think the ls2088a has 32 external lines, so it has to
> > be a least 0x1f).
> >
> > Also, this drops the fsl,bit-reverse property and instead reads the
> > SCFGREVCR register to determine if bit-reversing is needed.
> >
> > The dt/bindings patch now comes first in accordance with
> > Documentation/devicetree/bindings/submitting-patches.txt.
> >
> > Earlier versions can be found here:
> >
> > v6:
> > https://lore.kernel.org/lkml/20190923101513.32719-1-kurt@linutronix.de/
> > v5:
> >
> > https://lore.kernel.org/lkml/20180223210901.23480-1-rasmus.villemoes@prevas.dk/
> >
> > Rasmus Villemoes (2):
> >   dt/bindings: Add bindings for Layerscape external irqs
> >   irqchip: add support for Layerscape external interrupt lines
> >
> >  .../interrupt-controller/fsl,ls-extirq.txt    |  49 +++++
> >  drivers/irqchip/Kconfig                       |   4 +
> >  drivers/irqchip/Makefile                      |   1 +
> >  drivers/irqchip/irq-ls-extirq.c               | 197
> > ++++++++++++++++++
> >  4 files changed, 251 insertions(+)
> >  create mode 100644
> >
> > Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.txt
> >  create mode 100644 drivers/irqchip/irq-ls-extirq.c
>
> Applied to irqchip-next.
>
> Thanks,
>
>          M.
> --
> Jazz is not dead. It just smells funny...

A bit late, but for what it's worth,

Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Background: https://www.spinics.net/lists/netdev/msg611505.html

Thanks,
-Vladimir