Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6132858ybx; Mon, 11 Nov 2019 04:26:10 -0800 (PST) X-Google-Smtp-Source: APXvYqyvzyH9YqrjRbbAFC2YCfh/JQUQTAvs2+mo6QQO+HV/+BNI4hEoRlfWpgrFDQ+EEUm2oCBw X-Received: by 2002:a17:906:d71:: with SMTP id s17mr15823355ejh.312.1573475170676; Mon, 11 Nov 2019 04:26:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573475170; cv=none; d=google.com; s=arc-20160816; b=ev74vc7QQr8DDz6+ZamFF+jm62YIHKnNhW0iaHwJm3YFg+t7C9RZLBqNyFdkM8V1YC SQHT1wkzR3HwAm/M8iQ+GnG32f9e7ao/whfCFPLys/x1wzAhQ0NdgsJpsFP15m+5wCx0 AtqQTvL4A6DknYfGDb0paObOr9eK9R1GkEJtcMs1JfuOpRS1XlhWf2kYGmmbcFbl86gq FjP3QVTjWmNQlcy4Q0+gACzpvqS5YE9GIjTTqEDShyhH37daNQONGI26MiYLxRDszl+u x9A0Q9iqkrt21xMeesBOr1k5cDAr97QSFsEllobUAtloiP3SUfWgoaAOMdQqHVdmYOZ5 +27Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=oWcAEC9S5sxutdCNfKf4Dn4v+wiZLH2THzCZOEIaUqg=; b=Mnrx4OgcSINfKJdXIdLOSLOaEC9WBQlqF+7pGQhIZvwEYzh8c/6NxUEmTbPZ6k8htn cHBirncz+dYapZxUhTFeLsZt6nobYMjXU3ou6b0fb7Lar65OTxrYJ8KUkol6GLA/vpeR jfgXu/YgAf3olUuY7scowGO1KQ3rO33hGDLM4VSbEBsV8qOasmE31DAvD9SD7QUxtVUS 4e7ryu+k+5k/l+uAFHobixCK7W01RdvOLQzUf8EqG0hq13fAZvdUSTKrwdTM/+6Ytoro dOttUeadIvzetx9rqzLqY9ltKVhG0FWFtiHnofFqahWIRZSbOwnuvCsS1kQ/XZdyQJaZ bHSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x11si9789388edq.31.2019.11.11.04.25.46; Mon, 11 Nov 2019 04:26:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbfKKMY7 (ORCPT + 99 others); Mon, 11 Nov 2019 07:24:59 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:41858 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726811AbfKKMY6 (ORCPT ); Mon, 11 Nov 2019 07:24:58 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 289F912BCEF92F048447; Mon, 11 Nov 2019 20:24:55 +0800 (CST) Received: from localhost (10.133.213.239) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Mon, 11 Nov 2019 20:24:45 +0800 From: YueHaibing To: , , , CC: , , , YueHaibing Subject: [PATCH -next] virtiofs: Fix old-style declaration Date: Mon, 11 Nov 2019 20:23:59 +0800 Message-ID: <20191111122359.43624-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There expect the 'static' keyword to come first in a declaration, and we get warnings like this with "make W=1": fs/fuse/virtio_fs.c:687:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] fs/fuse/virtio_fs.c:692:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] fs/fuse/virtio_fs.c:1029:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: YueHaibing --- fs/fuse/virtio_fs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index b77acea..2ac6818 100644 --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -684,12 +684,12 @@ static int virtio_fs_restore(struct virtio_device *vdev) } #endif /* CONFIG_PM_SLEEP */ -const static struct virtio_device_id id_table[] = { +static const struct virtio_device_id id_table[] = { { VIRTIO_ID_FS, VIRTIO_DEV_ANY_ID }, {}, }; -const static unsigned int feature_table[] = {}; +static const unsigned int feature_table[] = {}; static struct virtio_driver virtio_fs_driver = { .driver.name = KBUILD_MODNAME, @@ -1026,7 +1026,7 @@ __releases(fiq->lock) } } -const static struct fuse_iqueue_ops virtio_fs_fiq_ops = { +static const struct fuse_iqueue_ops virtio_fs_fiq_ops = { .wake_forget_and_unlock = virtio_fs_wake_forget_and_unlock, .wake_interrupt_and_unlock = virtio_fs_wake_interrupt_and_unlock, .wake_pending_and_unlock = virtio_fs_wake_pending_and_unlock, -- 2.7.4