Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6183168ybx; Mon, 11 Nov 2019 05:16:36 -0800 (PST) X-Google-Smtp-Source: APXvYqwjuL0RS/itiezbcFhUi5P/s3vWErORSdR17nCKcqo63JEAKj5yu25rmcbp3694vnesnTKh X-Received: by 2002:a17:906:12d3:: with SMTP id l19mr21921574ejb.165.1573478196302; Mon, 11 Nov 2019 05:16:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573478196; cv=none; d=google.com; s=arc-20160816; b=s1jwWTdpvA8Eq1dVAVs3KrdyBtsLVDqXFJ3NH2GXEHaGtlm48WlrEyX9rCAhY4v9yl 8QPlKmaC6yV7aIke+SRIjPEdyhAx6QiqDaVRfKqQgA5GnEAJjPkcfC020VYDnCb70Ijx oTqo6lVygeXDAUcrNUOL+0b4geAwYmokHK5jLNWWA8Pj8N7Ph/UB36vH+gT9Fn+TJBK3 kCLTZLEKeylZ5SiJvBwsCuo6kZ7U7RuKNuf+iNNei2UbJHHKYrwPEdU+rV1Lp3GQf0av S5i70rfq46GMKvjTjG8g/LnqOYf4bVN0WHLPKWk+53VeInXAPnxFStDQ05QVOuXdKSo5 ewAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vSSh3GLhg1vsDC2+/ekTGoEZx+xBL7fSSkyIjDBus0Y=; b=YwC0toemnTM0ZDDufO++wkFmytAimsomq4FbQwDCdoOfVoWAtpclvxvEHpEthheu2q riAa43E4SWUu/mf1VS1h8KfvQyFFGkYm8RWX2Y1JGbX3OWMliRGb4cMo2lieEinAgeEX 2mibyga80sNE2+PdzW7nIFrCzly8aPGiboPTdeYRNcJicnwgTUOlT+tybzFIjjtaDDZS 02gdgCy0ccFABmGZ1DoQ/x/gr0bka4sMZJjAqWsWXHLv0KBl3B/Ro5DA0Zn+aSIujQ2c Jz9TaiqkNvDZbD5kQxWt3i+LkTdu4DbsvMYSKifXWVOxrWSBI0B7aEfExk1szeh/A5oe kRwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=Hbv7vTAJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t8si9365705ejj.328.2019.11.11.05.16.10; Mon, 11 Nov 2019 05:16:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=Hbv7vTAJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbfKKNOb (ORCPT + 99 others); Mon, 11 Nov 2019 08:14:31 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:38828 "EHLO mail-wm1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726845AbfKKNOb (ORCPT ); Mon, 11 Nov 2019 08:14:31 -0500 Received: by mail-wm1-f48.google.com with SMTP id z19so13158888wmk.3 for ; Mon, 11 Nov 2019 05:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vSSh3GLhg1vsDC2+/ekTGoEZx+xBL7fSSkyIjDBus0Y=; b=Hbv7vTAJaj3aLmwp1G2ep546uZEGDBhi+No53kbAa6wWPB2FUuSzQQNt4SsHuEN8GQ HOkbiVLgICe1ia9awIe0L/ZyaHt8V5FNGkmWEjYcJ3MwIay/64IGOcm/mM1XU2XSBZHg +NC8P6rEpo8CNdNh8I7JHCXqgbNRUvoRrrLk8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vSSh3GLhg1vsDC2+/ekTGoEZx+xBL7fSSkyIjDBus0Y=; b=oo7wj8bPPt0KLg81bN6x2inBvBdWQokONbyBkSROPctWkkbMa3WzOw8/d4gewUWWGQ 5RyrEYBVAxXrm74oP0ARDUBjPoJLFp1kbRPlxhYSFp8MGJbD0zCoc5ZYhXyl+esKBZeE lvVDE7SFCcRinvrUfnb2VeKqK6BcTE2d8/qTWSCeE+IZwq3pVMgdofBOviRXq7VW5hkU Og5HwHuSGQd0V/CW2SZfDAbhjrKdRE2IFlmk3vauNPnyPZemSEbJ0dEScBJqO3Vj7ked wLOQS7OWnHbsKTKGyCxiED4V0usHGtYN75VgVCh8j37Ch3js6DnRNogtAwlQTcIevpD/ yNdA== X-Gm-Message-State: APjAAAV4WPtmOnvhOEG5cfgEtW7s8n4/j3tCt9yAnpeSlGCLYzaCM3QK RQzJn28Hq/goVoiBS+WGv/Bjow== X-Received: by 2002:a1c:60d7:: with SMTP id u206mr21398439wmb.101.1573478068839; Mon, 11 Nov 2019 05:14:28 -0800 (PST) Received: from localhost ([2a01:4b00:8432:8a00:fa59:71ff:fe7e:8d21]) by smtp.gmail.com with ESMTPSA id u13sm6150007wmm.45.2019.11.11.05.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 05:14:28 -0800 (PST) Date: Mon, 11 Nov 2019 13:14:27 +0000 From: Chris Down To: Qian Cai Cc: akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, guro@fb.com, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm/vmscan: fix an undefined behavior for zone id Message-ID: <20191111131427.GB891635@chrisdown.name> References: <20191108204407.1435-1-cai@lca.pw> <64E60F6F-7582-427B-8DD5-EF97B1656F5A@lca.pw> <20191111130516.GA891635@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191111130516.GA891635@chrisdown.name> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris Down writes: >Ah, I just saw this in my local checkout and thought it was from my >changes, until I saw it's also on clean mmots checkout. Thanks for the >fixup! Also, does this mean we should change callers that may pass through zone_idx=MAX_NR_ZONES to become MAX_NR_ZONES-1 in a separate commit, then remove this interim fixup? I'm worried otherwise we might paper over real issues in future.