Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Nov 2019 14:30:20 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Andi Kleen <andi@firstfloor.org>
Cc:     jolsa@kernel.org, acme@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v5 10/13] perf stat: Use affinity for opening events
Message-ID: <20191111133020.GA12923@krava>
References: <20191107181646.506734-1-andi@firstfloor.org>
 <20191107181646.506734-11-andi@firstfloor.org>
MIME-Version: 1.0
In-Reply-To: <20191107181646.506734-11-andi@firstfloor.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 07, 2019 at 10:16:43AM -0800, Andi Kleen wrote:

SNIP

> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -1632,7 +1632,8 @@ void perf_evlist__force_leader(struct evlist *evlis=
t)
>  }
> =20
>  struct evsel *perf_evlist__reset_weak_group(struct evlist *evsel_list,
> -=09=09=09=09=09=09 struct evsel *evsel)
> +=09=09=09=09=09=09 struct evsel *evsel,
> +=09=09=09=09=09=09bool close)
>  {
>  =09struct evsel *c2, *leader;
>  =09bool is_open =3D true;
> @@ -1649,10 +1650,11 @@ struct evsel *perf_evlist__reset_weak_group(struc=
t evlist *evsel_list,
>  =09=09if (c2 =3D=3D evsel)
>  =09=09=09is_open =3D false;
>  =09=09if (c2->leader =3D=3D leader) {
> -=09=09=09if (is_open)
> +=09=09=09if (is_open && close)
>  =09=09=09=09perf_evsel__close(&c2->core);
>  =09=09=09c2->leader =3D c2;
>  =09=09=09c2->core.nr_members =3D 0;
> +=09=09=09c2->reset_group =3D true;

so it's only set to true and stays.. please explain the logic
in comment.. together with errored=20

thanks,
jirka