Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Nov 2019 15:04:15 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Andi Kleen <andi@firstfloor.org>
Cc:     jolsa@kernel.org, acme@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v5 13/13] perf stat: Use affinity for enabling/disabling
 events
Message-ID: <20191111140415.GA26980@krava>
References: <20191107181646.506734-1-andi@firstfloor.org>
 <20191107181646.506734-14-andi@firstfloor.org>
MIME-Version: 1.0
In-Reply-To: <20191107181646.506734-14-andi@firstfloor.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 07, 2019 at 10:16:46AM -0800, Andi Kleen wrote:

SNIP

> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 33080f79b977..571bb102b432 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -378,11 +378,28 @@ bool evsel__cpu_iter_skip(struct evsel *ev, int cpu=
)
>  void evlist__disable(struct evlist *evlist)
>  {
>  =09struct evsel *pos;
> +=09struct affinity affinity;
> +=09int cpu, i;

should we have the fallback to current code in here (and below) as well?
also for reading/openning?

jirka

> +
> +=09if (affinity__setup(&affinity) < 0)
> +=09=09return;
> +
> +=09evlist__for_each_cpu (evlist, i, cpu) {
> +=09=09affinity__set(&affinity, cpu);
> =20
> +=09=09evlist__for_each_entry(evlist, pos) {
> +=09=09=09if (evsel__cpu_iter_skip(pos, cpu))
> +=09=09=09=09continue;
> +=09=09=09if (pos->disabled || !perf_evsel__is_group_leader(pos) || !pos-=
>core.fd)
> +=09=09=09=09continue;
> +=09=09=09evsel__disable_cpu(pos, pos->cpu_iter - 1);
> +=09=09}
> +=09}
> +=09affinity__cleanup(&affinity);
>  =09evlist__for_each_entry(evlist, pos) {
> -=09=09if (pos->disabled || !perf_evsel__is_group_leader(pos) || !pos->co=
re.fd)
> +=09=09if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
>  =09=09=09continue;
> -=09=09evsel__disable(pos);
> +=09=09pos->disabled =3D true;
>  =09}
> =20
>  =09evlist->enabled =3D false;
> @@ -391,11 +408,28 @@ void evlist__disable(struct evlist *evlist)
>  void evlist__enable(struct evlist *evlist)
>  {
>  =09struct evsel *pos;
> +=09struct affinity affinity;
> +=09int cpu, i;
> =20
> +=09if (affinity__setup(&affinity) < 0)
> +=09=09return;
> +
> +=09evlist__for_each_cpu (evlist, i, cpu) {
> +=09=09affinity__set(&affinity, cpu);
> +
> +=09=09evlist__for_each_entry(evlist, pos) {
> +=09=09=09if (evsel__cpu_iter_skip(pos, cpu))
> +=09=09=09=09continue;
> +=09=09=09if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
> +=09=09=09=09continue;
> +=09=09=09evsel__enable_cpu(pos, pos->cpu_iter - 1);
> +=09=09}
> +=09}
> +=09affinity__cleanup(&affinity);
>  =09evlist__for_each_entry(evlist, pos) {
>  =09=09if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
>  =09=09=09continue;
> -=09=09evsel__enable(pos);
> +=09=09pos->disabled =3D false;
>  =09}
> =20
>  =09evlist->enabled =3D true;
> --=20
> 2.23.0
>=20