Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6552942ybx; Mon, 11 Nov 2019 10:50:38 -0800 (PST) X-Google-Smtp-Source: APXvYqwLIy0X5FwCJW4aspsbhCUqSkqOVfQWGON2IVvyILSdDzXjlxsG+LjX4jmOzeFnmGVcshEY X-Received: by 2002:aa7:db82:: with SMTP id u2mr27675624edt.256.1573498238283; Mon, 11 Nov 2019 10:50:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573498238; cv=none; d=google.com; s=arc-20160816; b=CbtckOzYmJ+w8W1mVkz8kW12UEx2OzF3BotOWfDc0EVr58Lfu32oxQfeOCCvde3kIK 3eAmXPBxu0mdtfnh6oMYkbSRV7WhUd1UoFm+Og/fKJ/5P+ErdACkJQTLSj3WN0azFQcF evHG0Evm0CH+eCflmtMWX7slcyMwxXhZJyzO5jNE4tDSngrWIk4xYAbSBGSfzAn+Wrzf OmLvqM5IMXuGwHZOEdsf9VlGPeOozwYKql7C6X6AFlJFnDcrXU81/K/LJX0C7xtvXQuU teOa7BgaCWHfWP9IK+I08B4RILWKWD1ijBTG9DJUZVfP5dTsH+e5jgULE51CeVV/UKMF oFxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3ekKE6tNnBc9udIkCVYOmJztwu3qcj5g2C72iS3g7tc=; b=tpJ/xzp/DhraxPgtjEQK93mFHqnvM2aEErnePBz7djBtA/dc7HZ8GlGo4tA3NPkpvq Lnbvz5wFCrGaGNX/0i30R3ZtRGlpcvA8vOV8P7euunx7jLFLEvRahigzJP0ibgkkKMHd fD16QZBVmc8iTptL795aDfpA1zmMZlKUFAr3Det/K3ZL2Dwrtr1ypsR18CW28xUWw/Uh MoNJR+Ecx9yNLz+bXuIOLJiDY3IGiw0u0viF6+rg1+4Lga4VtIkhPl4jsw1UgQq4RmfY qOAoDve2PmwCJuxt5ZnRi+wjGi/I5DhaadPIKvxwlZKUC+RI6jrf/2ymtGwdvPL7SU9d TkOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p7BOR1Ov; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jz12si9610793ejb.193.2019.11.11.10.50.13; Mon, 11 Nov 2019 10:50:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p7BOR1Ov; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730047AbfKKSq6 (ORCPT + 99 others); Mon, 11 Nov 2019 13:46:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:39558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729372AbfKKSq4 (ORCPT ); Mon, 11 Nov 2019 13:46:56 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9560520659; Mon, 11 Nov 2019 18:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498015; bh=x4KlDONvL5gFLEFToGLSxDIpUpyTrEGcLppi2wf6V8g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p7BOR1OvHuywYlvtZ6ty8cyoGs7q/Z8bQqOXOz5sVzgtNVbHii9UW2nYD/uv5amfQ C2wOK6TB+krvM8L18N2YhwduFvk4NWubdXUQBjhKKL4KY4VbtQ9G+yARFg0IVNRTvl bsTbj7JR+17PMV/gUa2Bo4Ci//WVdaXsVzrfxwlc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Himanshu Madhani , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 083/125] scsi: qla2xxx: Initialized mailbox to prevent driver load failure Date: Mon, 11 Nov 2019 19:28:42 +0100 Message-Id: <20191111181451.235535193@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181438.945353076@linuxfoundation.org> References: <20191111181438.945353076@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Himanshu Madhani [ Upstream commit c2ff2a36eff60efb5e123c940115216d6bf65684 ] This patch fixes issue with Gen7 adapter in a blade environment where one of the ports will not be detected by driver. Firmware expects mailbox 11 to be set or cleared by driver for newer ISP. Following message is seen in the log file: [ 18.810892] qla2xxx [0000:d8:00.0]-1820:1: **** Failed=102 mb[0]=4005 mb[1]=37 mb[2]=20 mb[3]=8 [ 18.819596] cmd=2 **** [mkp: typos] Link: https://lore.kernel.org/r/20191022193643.7076-2-hmadhani@marvell.com Signed-off-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_mbx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 84f57f075455e..128fcff24f1be 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -684,6 +684,7 @@ qla2x00_execute_fw(scsi_qla_host_t *vha, uint32_t risc_addr) mcp->mb[2] = LSW(risc_addr); mcp->mb[3] = 0; mcp->mb[4] = 0; + mcp->mb[11] = 0; ha->flags.using_lr_setting = 0; if (IS_QLA25XX(ha) || IS_QLA81XX(ha) || IS_QLA83XX(ha) || IS_QLA27XX(ha)) { @@ -727,7 +728,7 @@ qla2x00_execute_fw(scsi_qla_host_t *vha, uint32_t risc_addr) if (ha->flags.exchoffld_enabled) mcp->mb[4] |= ENABLE_EXCHANGE_OFFLD; - mcp->out_mb |= MBX_4|MBX_3|MBX_2|MBX_1; + mcp->out_mb |= MBX_4 | MBX_3 | MBX_2 | MBX_1 | MBX_11; mcp->in_mb |= MBX_3 | MBX_2 | MBX_1; } else { mcp->mb[1] = LSW(risc_addr); -- 2.20.1