Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6557066ybx; Mon, 11 Nov 2019 10:54:50 -0800 (PST) X-Google-Smtp-Source: APXvYqxlh63M6V+bZKvp89seMMqy05HI3rWul79Gq0AKOCHmsRvgk5ubGh+/vVGMvL/LrcUWnGQO X-Received: by 2002:aa7:c94b:: with SMTP id h11mr28298817edt.252.1573498490591; Mon, 11 Nov 2019 10:54:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573498490; cv=none; d=google.com; s=arc-20160816; b=eEA2ExajMqMMss0W9hCViG5leFsaaSABsfkNyWQlgqoU0FQqrN7733wKhZR2jZwf9Q qEksfqdzCUTGf38Kds6IOYUL/B6uKrB5btGBEOr4bM9xRDzVkluM+LWIiG0dcjN6UoA5 baTR2WkRURKmCzVGPS4I4IDB89p9rTvIwyaUEpAIFL1ar8PaWUqWqV3taGlUs5B4zYcM /Lwk1t/1DZrk7Fz2++ubQqieoZ90Q4ki07VoH0JRt2DXoGXcNvllgws2fpK6/GHD5zIG jDItIhJ5g6HdQuDq2K2CUt9a1wsno+VKrcbkn0rXZW8BolhWKK892rI6JJ/+LSv6hJJo bP/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dNRRf+CLy2T/ljFHUIrr2G+o1COvDYcODMbjRLtdmko=; b=DapE/EKCI82aVS+i7vI8OP0u8bYvkSRMW90iAMJO9e/OSFQKSXxy/N+zPJp3ICTGay asvWfFfHZD3ZVZJwnXOzw1FbJr3coKLBXJ/ZtyXFz/pXjf3plFy0p0UoV5TUA3pRHmFs V4hyak846Ljktf5udFUmPKTt2l5zCWIS/E3p85FJRMu6qZKf7eb+MS62Sbjci8z75l8l jusF9V3k4wnfkrAlsXLb9jes48B/qTnFJsHv40OJ6wr4nwbykq4JgClzHpSjEtscKUIQ USd3SsdBBRQHltFHznfxEo2CIiZ7IOKz+mXfKnCKtd7dpwbYjHIr5XMKdfxHT/Uupdpw e4QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fdVEXvXg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p57si10043671edc.295.2019.11.11.10.54.26; Mon, 11 Nov 2019 10:54:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fdVEXvXg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730424AbfKKSxz (ORCPT + 99 others); Mon, 11 Nov 2019 13:53:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:49092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729260AbfKKSxx (ORCPT ); Mon, 11 Nov 2019 13:53:53 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C04D921783; Mon, 11 Nov 2019 18:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498433; bh=tkG/7XE93bwOWzGz6iLk765b1fbL6BXtghTwdX2w60A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fdVEXvXg29R72HxDBMl1YZsDEbig63kq9l4BWj3EMCN27HNmokDCx+z8v4lbnuyp0 izsKQRFnRk6qgqbdZVcsBb2SQkG2mpz4rRXLnA3Z23i/sDmfgHYKyURWGigp2EDpR1 1gxUMqRXdTbtk0OJ1DONCdMOwl/YGD4TSoWX63MM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Himanshu Madhani , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.3 119/193] scsi: qla2xxx: Initialized mailbox to prevent driver load failure Date: Mon, 11 Nov 2019 19:28:21 +0100 Message-Id: <20191111181509.947823219@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181459.850623879@linuxfoundation.org> References: <20191111181459.850623879@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Himanshu Madhani [ Upstream commit c2ff2a36eff60efb5e123c940115216d6bf65684 ] This patch fixes issue with Gen7 adapter in a blade environment where one of the ports will not be detected by driver. Firmware expects mailbox 11 to be set or cleared by driver for newer ISP. Following message is seen in the log file: [ 18.810892] qla2xxx [0000:d8:00.0]-1820:1: **** Failed=102 mb[0]=4005 mb[1]=37 mb[2]=20 mb[3]=8 [ 18.819596] cmd=2 **** [mkp: typos] Link: https://lore.kernel.org/r/20191022193643.7076-2-hmadhani@marvell.com Signed-off-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_mbx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index abfb9c800ce28..ac4640f456786 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -710,6 +710,7 @@ qla2x00_execute_fw(scsi_qla_host_t *vha, uint32_t risc_addr) mcp->mb[2] = LSW(risc_addr); mcp->mb[3] = 0; mcp->mb[4] = 0; + mcp->mb[11] = 0; ha->flags.using_lr_setting = 0; if (IS_QLA25XX(ha) || IS_QLA81XX(ha) || IS_QLA83XX(ha) || IS_QLA27XX(ha) || IS_QLA28XX(ha)) { @@ -754,7 +755,7 @@ qla2x00_execute_fw(scsi_qla_host_t *vha, uint32_t risc_addr) if (ha->flags.exchoffld_enabled) mcp->mb[4] |= ENABLE_EXCHANGE_OFFLD; - mcp->out_mb |= MBX_4|MBX_3|MBX_2|MBX_1; + mcp->out_mb |= MBX_4 | MBX_3 | MBX_2 | MBX_1 | MBX_11; mcp->in_mb |= MBX_3 | MBX_2 | MBX_1; } else { mcp->mb[1] = LSW(risc_addr); -- 2.20.1