Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6577796ybx; Mon, 11 Nov 2019 11:14:17 -0800 (PST) X-Google-Smtp-Source: APXvYqwBRu/k8POvli6W9umHdllIvvQ6kr0S4/CI18Jdh8HRi1HgXsZiXjQrjOxFHn0v9brL/9w7 X-Received: by 2002:a50:ec89:: with SMTP id e9mr28506444edr.104.1573499657024; Mon, 11 Nov 2019 11:14:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573499657; cv=none; d=google.com; s=arc-20160816; b=q5AKN8vD0oLt0TL0p2dyP1frhdFZx90doOX8vX83fkZyUXHfYDH3H/i1wFQVC01nro XUb+jcbqai8d/iLyDyP3z6QMtIrPyJUv4BEstjHUvY8ae0jQUTSb6tRi9Si27oO74jsi /+tf8wIARWxXVF34QluBCqpEnxgzdTc0kKk7vOUyCj1wOINndG6eWvgmtShAmh08AjYL pkcDWrEZJLt0DKlxxeH/G96/UPnQsh7ncwl8frqmA9fYNpbnVp/Plc9XeOnxelpq8zm6 52Fi0dqm87v7slnHvKqmBA3QpyYHnYUfFUlS8pynhRTGIz2FhpPmHEsbqa4GoVQ+6ikQ zQmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dlgbQ9AS3ka7sx/BBtNOpeMgWZzAP/theqKtm3T7d18=; b=Hq6LYU4MT47LVfBkP2ZVBCmE/koX2tIEWBsSGymITw8wYkblevU6iQtgho/qlLmmMu ugR+dMtRibP47VHfLySOM2ClkPBBTHvfqsbNGq3ae0AdmxClnwMzRiWTeAZddQ3zeU48 dFSecxud1YOULNve40dL+/i0Qh5hfLH36ynLV1bZkcoDlWTJCMxjZlm/jDGEuiJ0T1sz chq+RlSRmkdsMw3gM6gpFQvZnQjksNiavaFHI+Zg2m2gI3fwAKqPuxvQxNtwIOQizSqt YDv6bKEhwdwxwDlk/uMrrV+CCnEoThJaa3v6D2wkSWLyO0t2JnOmkHF00aXf3KP13iJy f5Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0gLYt0yZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ca22si10088392ejb.22.2019.11.11.11.13.52; Mon, 11 Nov 2019 11:14:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0gLYt0yZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727324AbfKKSa3 (ORCPT + 99 others); Mon, 11 Nov 2019 13:30:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:46740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbfKKSa2 (ORCPT ); Mon, 11 Nov 2019 13:30:28 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4856A21872; Mon, 11 Nov 2019 18:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497026; bh=gpJkM8tSzbzYkk30CQsNGrRPwbI6TaIqNSKozZigDIs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0gLYt0yZVyJew8ysSKKpObXg4AOtn3SpA2nvsnJjIj+K2cY0Eeo06s20TG7148+73 Rkc3sZq298Z5zCdihztRyCdNd2YSVqlOPWkTJMy0tNVVjRNGS5XY+0TnJJFNg1eXnT cTYKhvMW5zwLcA5zaKFlLT/S3JY9hKcGh/hbIavM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , "David S. Miller" Subject: [PATCH 4.4 03/43] NFC: fdp: fix incorrect free object Date: Mon, 11 Nov 2019 19:28:17 +0100 Message-Id: <20191111181252.561390022@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181246.772983347@linuxfoundation.org> References: <20191111181246.772983347@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit 517ce4e93368938b204451285e53014549804868 ] The address of fw_vsc_cfg is on stack. Releasing it with devm_kfree() is incorrect, which may result in a system crash or other security impacts. The expected object to free is *fw_vsc_cfg. Signed-off-by: Pan Bian Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/nfc/fdp/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/nfc/fdp/i2c.c +++ b/drivers/nfc/fdp/i2c.c @@ -268,7 +268,7 @@ static void fdp_nci_i2c_read_device_prop *fw_vsc_cfg, len); if (r) { - devm_kfree(dev, fw_vsc_cfg); + devm_kfree(dev, *fw_vsc_cfg); goto vsc_read_err; } } else {