Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161550AbWAMKpC (ORCPT ); Fri, 13 Jan 2006 05:45:02 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161551AbWAMKpB (ORCPT ); Fri, 13 Jan 2006 05:45:01 -0500 Received: from mail15.syd.optusnet.com.au ([211.29.132.196]:64184 "EHLO mail15.syd.optusnet.com.au") by vger.kernel.org with ESMTP id S1161550AbWAMKpA (ORCPT ); Fri, 13 Jan 2006 05:45:00 -0500 From: Con Kolivas To: Andrew Morton Subject: Re: [PATCH 1/5] sched-cleanup_task_activated.patch Date: Fri, 13 Jan 2006 21:44:41 +1100 User-Agent: KMail/1.9 Cc: linux-kernel@vger.kernel.org, mingo@elte.hu References: <200601132123.01338.kernel@kolivas.org> <20060113022819.432a1b6d.akpm@osdl.org> In-Reply-To: <20060113022819.432a1b6d.akpm@osdl.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200601132144.41524.kernel@kolivas.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 33 On Friday 13 January 2006 21:28, Andrew Morton wrote: > Con Kolivas wrote: > > +enum sleep_type { > > + SLEEP_NORMAL, > > + SLEEP_NONINTERACTIVE, > > + SLEEP_INTERACTIVE, > > + SLEEP_INTERRUPTED, > > +}; > > If you make these 1, 2, 4 and 8 > > > +static inline int interactive_sleep(enum sleep_type sleep_type) > > +{ > > + return (sleep_type == SLEEP_INTERACTIVE || > > + sleep_type == SLEEP_INTERRUPTED); > > +} > > then this can be > > return sleep_type & (SLEEP_INTERACTIVE|SLEEP_INTERRUPTED); > > which would save, oh, about nothing. Hah yeah I went for readability over one cycle. Change it if you care; I don't mind :). Cheers, Con - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/