Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191108210236.1296047-1-arnd@arndb.de> <20191108211323.1806194-4-arnd@arndb.de>
In-Reply-To: <20191108211323.1806194-4-arnd@arndb.de>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 11 Nov 2019 21:24:51 +0100
Message-ID: <CAK8P3a2k-ZHAiCMBHWHvtwRfYqnz7aFGfqSYT8sLSyOf7Dm8Aw@mail.gmail.com>
Subject: Re: [PATCH 13/23] y2038: socket: remove timespec reference in timestamping
To:     y2038 Mailman List <y2038@lists.linaro.org>,
        "David S. Miller" <davem@davemloft.net>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        Willem de Bruijn <willemb@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Networking <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 8, 2019 at 10:15 PM Arnd Bergmann <arnd@arndb.de> wrote:

> diff --git a/include/uapi/linux/errqueue.h b/include/uapi/linux/errqueue.h
> index 28491dac074b..0cca19670fd2 100644
> --- a/include/uapi/linux/errqueue.h
> +++ b/include/uapi/linux/errqueue.h
> @@ -37,9 +37,16 @@ struct sock_extended_err {
>   *     The timestamping interfaces SO_TIMESTAMPING, MSG_TSTAMP_*
>   *     communicate network timestamps by passing this struct in a cmsg with
>   *     recvmsg(). See Documentation/networking/timestamping.txt for details.
> + *     User space sees a timespec definition that matches either
> + *     __kernel_timespec or __kernel_old_timespec, in the kernel we
> + *     require two structure definitions to provide both.
>   */
>  struct scm_timestamping {
> +#ifdef __KERNEL__
> +       struct __kernel_old_timespec ts[3];
> +#else
>         struct timespec ts[3];
> +#endif
>  };

The kbuild bot pointed out that the way I sent this series, the use of
__kernel_old_timespec
causes a build failure, because I introduce this in a separate submission. I'm
moving this patch over to the other series, and changing the subject to

y2038: socket: use __kernel_old_timespec instead of timespec

With the expectation of merging it along with the other core patches.

      Arnd