Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6665040ybx; Mon, 11 Nov 2019 12:39:14 -0800 (PST) X-Google-Smtp-Source: APXvYqwS/dgXrhpJJI2HGuq8X/J5gs5MvsQjzd2xRLgyfSnpjVgmRQUgzgoNVoW41fuCDGpdULyh X-Received: by 2002:a17:906:7c4e:: with SMTP id g14mr24315556ejp.150.1573504754436; Mon, 11 Nov 2019 12:39:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573504754; cv=none; d=google.com; s=arc-20160816; b=ebG+BAJZqueYFUatqH0lqcvb5LjlylQk1HAswezyYyU35wJHWIpfLxcYV24T5nVtdD wzNnS81k1EcZShRstHKiam86AqhWb96tT0XCM8KuO7g2MmM1X6cIs0bfXPGC9yfxBJl8 qyxu0w3GJKH2jPaLxorQNazHnK9ODGujIYgjDSd/nsDvGehfoHOrvnnxovWa+yJyi9JS AxgxqnO5l+9mSFim29ejKn6A3yQ9wyPBQxpM7Hs796W0m0Yp7gAHEs1roCotiWQyXiVJ w9WefouS61o3Xg6GIlQeTsKxwLxufVEPib1ZLTuY0y64VEviS6g3aEeB1NOg8x1NzruS DcHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=N+OkbnSznqo9YIntW1+MXmUwjcpyGyYGisdGsT7N/WM=; b=MKbu7NcGc0JTUi6g58KenBb5grYQA9+cKC4RYbUXKiCNm2d9bd4O7fZKVAAR5n1f9U q5zntejtxsJA1ZwxG++KF6C1rnn+OhJiMapnCsVCfWvxXFD+qBrPGcSAnR9Lf5Kli5AB fNnBQBJa49+nUoylcaU16HYIh2IR7GDRdvHWncuy6CHou1IDitFUNgtjRqd7yzvTInCM 9uGyyJaV2tN4gmyIfAynj9RKxKLjKFo/2pt7k0TN4eM8jD7Tc6y1+R/cplZ4QWsFAhhk HWuXz/1s696EJA3+ZGbK4PsOZSZd/ONtxHKm7RcDTIewmVyuy/f8DzAqjjYk9Tpbn9hb 5jmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a30si11633649eda.259.2019.11.11.12.38.50; Mon, 11 Nov 2019 12:39:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbfKKUhq (ORCPT + 99 others); Mon, 11 Nov 2019 15:37:46 -0500 Received: from verein.lst.de ([213.95.11.211]:51892 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726939AbfKKUhq (ORCPT ); Mon, 11 Nov 2019 15:37:46 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 45C7368B05; Mon, 11 Nov 2019 21:37:43 +0100 (CET) Date: Mon, 11 Nov 2019 21:37:43 +0100 From: Christoph Hellwig To: Alan Mikhak Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-nvme@lists.infradead.org, kishon@ti.com, lorenzo.pieralisi@arm.com, bhelgaas@google.com, hch@lst.de, palmer@dabbelt.com, paul.walmsley@sifive.com Subject: Re: [PATCH RFC] PCI: endpoint: Add NVMe endpoint function driver Message-ID: <20191111203743.GA25876@lst.de> References: <1573493889-22336-1-git-send-email-alan.mikhak@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1573493889-22336-1-git-send-email-alan.mikhak@sifive.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 09:38:09AM -0800, Alan Mikhak wrote: > A design goal is to not modify the Linux NVMe target driver > at all. As I told you before that is not a "goal" but a fundamental mistake and against the design philosophy of all major Linux subsystems. Please fix your series to move all command parsing to the code based on flags for fabrics vs PCIe in the few places where they significantly differ.