Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6792290ybx; Mon, 11 Nov 2019 15:00:32 -0800 (PST) X-Google-Smtp-Source: APXvYqzVo3rt/Du+J1A2aXJXuh073rKJ00LUv4Eu4faYPspMwY1MfGKGerlXIcgvtu+793Ij+nV0 X-Received: by 2002:a17:906:4e48:: with SMTP id g8mr6314752ejw.67.1573513232361; Mon, 11 Nov 2019 15:00:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573513232; cv=none; d=google.com; s=arc-20160816; b=NJRWQwPNuurjjnItpgKpwrcQE1DmLgyIvba0ifemhyl0wPx4vIcEw2Mi5AtxaIdgYk TA/q+69pJ3P04NDl+R6GAYuAHgixVZvyuTxsv6WGjRnBSw4sZV5N7H7Zi6xQLvTWbYkU Uo0+SB2AG/d+XFfZW6onWdSDRoCqgMhguhoZh5D/MkKd4j6qnpCNRce1V23eJ2luxQKu dFZpD12E9RGyd1jj0LbuqOdjZesxNCWL0BEOu8FQ0EYmYw+pLNS0qW81Z6hGB5yYaMsl BvDNW2Tr/ek0ZfSvyXmQsdbfmq1fCMG94iczgnN1h+Rtv1E7G1v7G5u636V6hpzIsykg ng6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=iPQod+9cHZwTZSp0ehxuPcKaePnfqhyfvY+Ryo1C3ks=; b=WMocojN0ur6cAg41OlXik9GbM3iwQJYpUcpFAEdX+WkUNqtyg445r4RoxR1lFCvkEz f5JjTK8M7Q9zQ69UNPiXuFLAPzxfFDE9o0A2j5G8jm6pj8I2d4U575Z3rbOXrhTHB/WL b4O9fY5qv2XV9NF6yCuZVJUwenobSBGkBZByZgiMQYUEvdgmasvIlZwXpWR1eV0S/Tdu SGMWwhdXfZNZA42LfrCNiKGU2JQZuE2IHlOhAFOoU/liXpRHPbXemMPzZdmc9fqAaLGn YPJ1HFPBQSPAzAVlzSAO6lnKVxB93KdPPfi/oLu7HcWwoyZ9+nlj4lYS4q12IijtAyU0 ZT6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Rj/HCH/z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a25si10634755ejb.285.2019.11.11.15.00.06; Mon, 11 Nov 2019 15:00:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Rj/HCH/z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbfKKW4O (ORCPT + 99 others); Mon, 11 Nov 2019 17:56:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:57678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726877AbfKKW4O (ORCPT ); Mon, 11 Nov 2019 17:56:14 -0500 Received: from localhost (lfbn-ncy-1-150-155.w83-194.abo.wanadoo.fr [83.194.232.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57F4A20659; Mon, 11 Nov 2019 22:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573512973; bh=Z3qpgytwGG/uM8u/1Veq7O94/qCL6tFO45pqS6ZAmOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rj/HCH/zb307UBe50EiURObwyYmarROa0C5OArwZ7/eka01/4riFU2QdBwpSCWDI0 AvpLAoOVBO6MoZ9KibjlFQaGVS4nOkJeZQAJhA+LaCN7wewZRLNykPgdrf50AcKziV M9zekoVIJznDJ4WdxgJm/7P+Sqa7CwyTjn3pU6uI= Date: Mon, 11 Nov 2019 23:56:11 +0100 From: Frederic Weisbecker To: Ingo Molnar Cc: Peter Zijlstra , LKML , "Paul E . McKenney" , Thomas Gleixner Subject: Re: [PATCH 1/4] irq_work: Convert flags to atomic_t Message-ID: <20191111225610.GB27917@lenoir> References: <20191108160858.31665-1-frederic@kernel.org> <20191108160858.31665-2-frederic@kernel.org> <20191111080058.GA72562@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111080058.GA72562@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 09:00:58AM +0100, Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > We need to convert flags to atomic_t in order to later fix an ordering > > issue on cmpxchg() failure. This will allow us to use atomic_fetch_or(). > > Also that clarify the nature of those flags. > > > > Signed-off-by: Frederic Weisbecker > > Cc: Paul E. McKenney > > Cc: Thomas Gleixner > > Cc: Peter Zijlstra > > Cc: Ingo Molnar > > --- > > include/linux/irq_work.h | 10 +++++++--- > > kernel/irq_work.c | 18 +++++++++--------- > > kernel/printk/printk.c | 2 +- > > 3 files changed, 17 insertions(+), 13 deletions(-) > > You missed the irq_work use in kernel/bpf/stackmap.c - see the fix below. > > Thanks, > > Ingo Oh thanks. Strange that I haven't seen a 0-day warning about those.