Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Nov 2019 18:12:28 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Tony Lu <tonylu@linux.alibaba.com>
Cc:     mingo@redhat.com, sanagi.koki@jp.fujitsu.co, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] net: add missing semicolon in net_dev_template
Message-ID: <20191111181228.49396467@gandalf.local.home>
In-Reply-To: <20191111141752.31655-1-tonylu@linux.alibaba.com>
References: <20191111141752.31655-1-tonylu@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 11 Nov 2019 22:17:53 +0800
Tony Lu <tonylu@linux.alibaba.com> wrote:

> This patch adds missing semicolon in the end of net_dev_template.
> 
> Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
>  include/trace/events/net.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/net.h b/include/trace/events/net.h
> index 2399073c3afc..3b28843652d2 100644
> --- a/include/trace/events/net.h
> +++ b/include/trace/events/net.h
> @@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
>  
>  	TP_printk("dev=%s skbaddr=%p len=%u",
>  		__get_str(name), __entry->skbaddr, __entry->len)
> -)
> +);

Actually, we are thinking of making a sweeping patch set to remove all
these semicolons, as they are not needed, and would also allow more
flexible processing of the trace event macros.

-- Steve

>  
>  DEFINE_EVENT(net_dev_template, net_dev_queue,
>