Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Nov 2019 15:31:25 -0800
From:   Andi Kleen <andi@firstfloor.org>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
        jolsa@kernel.org, acme@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 13/13] perf stat: Use affinity for enabling/disabling
 events
Message-ID: <20191111233124.sg4g7rkwa4g4u7al@two.firstfloor.org>
References: <20191107181646.506734-1-andi@firstfloor.org>
 <20191107181646.506734-14-andi@firstfloor.org>
 <20191111140415.GA26980@krava>
 <20191111165028.GC573472@tassilo.jf.intel.com>
 <20191111200655.GB31193@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191111200655.GB31193@krava>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> then let's have some assert or BUG_ON on !all_cpus
> and remove the fallback code from close path

I tried it again, but in record mode evsel->cpus is usually NULL,
resulting in various crashes.

I think fixing this beyond the scope of this patchkit, so i will
keep the fallback checks for now. I'll add better comments though.

-Andi