Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     Eric Dumazet <edumazet@google.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] powerpc: add const qual to local_read() parameter
In-Reply-To: <20191108141353.193961-1-edumazet@google.com>
References: <20191108141353.193961-1-edumazet@google.com>
Date:   Tue, 12 Nov 2019 10:38:56 +1100
Message-ID: <87y2wm2dbj.fsf@mpe.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Eric Dumazet <edumazet@google.com> writes:
> A patch in net-next triggered a compile error on powerpc.

Would be nice to mention the compiler error, I haven't seen the report.

> This seems reasonable to relax powerpc local_read() requirements.

Seems fine.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

Dave can you please put this in net-next to limit the window of
breakage.

cheers

> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc:	Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc:	Paul Mackerras <paulus@samba.org>
> Cc:	Michael Ellerman <mpe@ellerman.id.au>
> Cc:	linuxppc-dev@lists.ozlabs.org

Seems it didn't actually get cc'ed to linuxppc-dev for some reason.

> ---
>  arch/powerpc/include/asm/local.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
> index fdd00939270bf08113b537a090d6a6e34a048361..bc4bd19b7fc235b80ec1132f44409b6fe1057975 100644
> --- a/arch/powerpc/include/asm/local.h
> +++ b/arch/powerpc/include/asm/local.h
> @@ -17,7 +17,7 @@ typedef struct
>  
>  #define LOCAL_INIT(i)	{ (i) }
>  
> -static __inline__ long local_read(local_t *l)
> +static __inline__ long local_read(const local_t *l)
>  {
>  	return READ_ONCE(l->v);
>  }
> -- 
> 2.24.0.432.g9d3f5f5b63-goog