Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp124465ybc;
        Mon, 11 Nov 2019 21:49:20 -0800 (PST)
X-Google-Smtp-Source: APXvYqwd9imNmfPjj27+NSaWtX4C/Qg9/mYlmqG3S6urkO5yJtz0AHVN2zqcKHWbFaF6xvjWApw9
X-Received: by 2002:a05:6402:1156:: with SMTP id g22mr31256958edw.233.1573537760241;
        Mon, 11 Nov 2019 21:49:20 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1573537760; cv=none;
        d=google.com; s=arc-20160816;
        b=QmmZqZBwikr22/NGSqk+Xog7lRMXxm2XuuaOsaxebMun4JBddgUoSQV7/SlbB5nNYP
         Uqd9kYSkRJfLxOeJ2n7g8neoTmwiokMD12FKCMYwtQThCtAzGUwXRDMJ8rsJhLXFTjb7
         bwrMDaJkkO+3x/O6jzSZgLcSJN6tmR4Rdq/eQeJpgdeLySKc51UhlZEnBSWHpf0hsbA2
         yJt4TMIsUtplWEruGytlkVBF4hTeT504mtvNerOOgRMeRRY7IviitAHW8foAupTzZ4Pd
         CfYs61N0Ip1hwuiXlf6/3GH1f1NENjO5durVmQU8gebftujJ9eOgeiuSJUqgwIekRsew
         sFAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date
         :dkim-signature;
        bh=UBqjouGw3TH1iaQ7iP1CayKO4c2WZUu/AVL/DYGbLDM=;
        b=oXIWHsUcVleCINwMheiTbsgzvC+Wq/o/TBecaYIaBhcyfEGLPGq9tXv2dlP+f5kFdM
         BJhHiIoDQt2DDFVAeMAnkuTSg4qh2BMqlH8Zxm+6HDtb+kqkylvK7b7GvgDPS0aUzOWu
         1iR2otWAB6Svv3m2wB0uQixZoUT2hqouaWjWm5FTySs9faLVX6ll32mgonV9a36D6Nos
         Vouo3OAaxgJIfxq8fImmsP3wVhClND/4ZD4EsKIUyDs04J6xMCk3lLIb1/Ft6QtCBhij
         KIiz6GmDpimz6W9vFuHruU/db6jcm1Sg2XbrgYZEUT26TTO3JWtLwlQ62XxtGZglm1Du
         OeJg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QFTUytoa;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id b17si10943373ejp.326.2019.11.11.21.48.55;
        Mon, 11 Nov 2019 21:49:20 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QFTUytoa;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725957AbfKLFrH (ORCPT <rfc822;ayiehere@gmail.com> + 99 others);
        Tue, 12 Nov 2019 00:47:07 -0500
Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:26665 "EHLO
        us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1725775AbfKLFrH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Nov 2019 00:47:07 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
        s=mimecast20190719; t=1573537626;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=UBqjouGw3TH1iaQ7iP1CayKO4c2WZUu/AVL/DYGbLDM=;
        b=QFTUytoaPqSrw4YDgCusZzXtQvYzY3PaRYo4c8Hd97/Rdq3bkedp1X+GBzPQ3uH5yF1nGz
        RYMXJqoV20XaJbTOaOMxhU4Hr9ezuHXjrzSoQnMvfuOEBSVYYdsry9oMNzHv/Fj1wri4U/
        737210uAj5wrJ02wAvFM95qdcR0GNSc=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-334-jR0LROUlONuAV20I3GQI8Q-1; Tue, 12 Nov 2019 00:47:02 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 82B98801E4F;
        Tue, 12 Nov 2019 05:47:01 +0000 (UTC)
Received: from localhost (ovpn-112-54.rdu2.redhat.com [10.10.112.54])
        by smtp.corp.redhat.com (Postfix) with ESMTP id BBD085C883;
        Tue, 12 Nov 2019 05:46:59 +0000 (UTC)
Date:   Mon, 11 Nov 2019 21:46:58 -0800 (PST)
Message-Id: <20191111.214658.1031500406952713920.davem@redhat.com>
To:     olof@lixom.net
Cc:     andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mdio-octeon: Fix pointer/integer casts
From:   David Miller <davem@redhat.com>
In-Reply-To: <20191111004211.96425-1-olof@lixom.net>
References: <20191111004211.96425-1-olof@lixom.net>
Mime-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-MC-Unique: jR0LROUlONuAV20I3GQI8Q-1
X-Mimecast-Spam-Score: 0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Olof Johansson <olof@lixom.net>
Date: Sun, 10 Nov 2019 16:42:11 -0800

> -static inline void oct_mdio_writeq(u64 val, u64 addr)
> +static inline void oct_mdio_writeq(u64 val, void __iomem *addr)
>  {
> -=09cvmx_write_csr(addr, val);
> +=09cvmx_write_csr((u64)addr, val);
>  }

I hate stuff like this, I think you really need to fix this from the bottom
up or similar.  MMIO and such addresses are __iomem pointers, period.