Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Nov 2019 21:50:47 -0800 (PST)
Message-Id: <20191111.215047.316217567209805516.davem@redhat.com>
To:     po.liu@nxp.com
Cc:     claudiu.manoil@nxp.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, vinicius.gomes@intel.com,
        vladimir.oltean@nxp.com, alexandru.marginean@nxp.com,
        xiaoliang.yang_1@nxp.com, roy.zang@nxp.com, mingkai.hu@nxp.com,
        jerry.huang@nxp.com, leoyang.li@nxp.com
Subject: Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via
 tc-taprio offload
From:   David Miller <davem@redhat.com>
In-Reply-To: <20191111042715.13444-1-Po.Liu@nxp.com>
References: <20191111042715.13444-1-Po.Liu@nxp.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Po Liu <po.liu@nxp.com>
Date: Mon, 11 Nov 2019 04:41:26 +0000

> +fsl-enetc-$(CONFIG_NET_SCH_TAPRIO) +=3D enetc_qos.o

Code is Kconfig guarded.
> +=09case TC_SETUP_QDISC_TAPRIO:
> +=09=09return enetc_setup_tc_taprio(ndev, type_data);

Yet invoked unconditionally.

I can see just by reading your code that various configurations will
result in link errors.

 ...
> +int enetc_setup_tc_taprio(struct net_device *ndev, void *type_data)
> +{
> +=09struct tc_taprio_qopt_offload *taprio =3D type_data;
> +=09struct enetc_ndev_priv *priv =3D netdev_priv(ndev);
> +=09int i;
> +
> +=09for (i =3D 0; i < priv->num_tx_rings; i++)
> +=09=09enetc_set_bdr_prio(&priv->si->hw,
> +=09=09=09=09   priv->tx_ring[i]->index,
> +=09=09=09=09   taprio->enable ? i : 0);
> +
> +=09return enetc_setup_taprio(ndev, taprio);
> +}
> --=20
> 2.17.1
>=20