Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Nov 2019 22:01:37 -0800 (PST)
Message-Id: <20191111.220137.766852670780646785.davem@redhat.com>
To:     yuehaibing@huawei.com
Cc:     andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
        mail@david-bauer.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mdio_bus: Fix PTR_ERR applied after initialization to
 constant
From:   David Miller <davem@redhat.com>
In-Reply-To: <20191111071347.21712-1-yuehaibing@huawei.com>
References: <20191111071347.21712-1-yuehaibing@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: YueHaibing <yuehaibing@huawei.com>
Date: Mon, 11 Nov 2019 15:13:47 +0800

> Fix coccinelle warning:
>=20
> ./drivers/net/phy/mdio_bus.c:67:5-12: ERROR: PTR_ERR applied after initia=
lization to constant on line 62
> ./drivers/net/phy/mdio_bus.c:68:5-12: ERROR: PTR_ERR applied after initia=
lization to constant on line 62
>=20
> Fix this by using IS_ERR before PTR_ERR
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 71dd6c0dff51 ("net: phy: add support for reset-controller")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.