Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp179466ybc; Mon, 11 Nov 2019 23:02:51 -0800 (PST) X-Google-Smtp-Source: APXvYqxHZ8t7kZMgzslkm9eKF4CqDmhjLJvpts688udwoiScIV8RKp05PUkBgqTWdRtHGif9Z5/Z X-Received: by 2002:a17:906:70ca:: with SMTP id g10mr24125752ejk.141.1573542171763; Mon, 11 Nov 2019 23:02:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573542171; cv=none; d=google.com; s=arc-20160816; b=g2FDafpZQBMuDdrvJ3Xco+TfYA1wYYErdODk+MwGsfWN1JGJ+6bYkSHMbNoqPf5As8 QPaSDWMWaQSVvm5/6gbV0UOSScDOAbjGzRk+zoUCFiL8KKvn9ovG3JwDWX0kafyJjMEv uWrBBXJ1S6ZR6dZUVDikN3/7q9m7bl1FcCZCOKwfyWnf+K5z1D0h/EiojyMjyoAn16Mh FvntigKZj/7GZwvKwFyLpxKHfvF1arisvTz7fkwvqEURJvrXQ1VbpQ6HNeMPiX/3uvhz li2v0CED3ARJNA0etnbriEXWZ2TmnIrQdgCPKq7lwZI+wES3Kwz3FouAwsxhNIkBK1+e GacA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=2yiA9jJ8XxA99SOzEqsi9UPB3hjnaBPlGcGeO0QArcw=; b=o5pWLMmUU8MrSXu6dDppo1aM0wiczduYGdBUJaP+j6MiJN0f1o8RJ6Aw+3SaiXrBaA yZwpY/vY3djQVJl+Gls39dfD+xXImc5nz/jw1TqaH9BB6h1jq84XKWyR+17thGILsaa0 wKQ9ksMUThhdxCbaQoO5u84YbKg9LJR/CRdqBvj19Xwy7MowI6rvXcpNfwUc46LeRZoQ 3Ko6QzRrejt9236h8Mtl4FyzYwUW7ub5XLOntVT6LMWhkr1lGZWy/UMVFmaBO7MbCeAV EUNMqy/qjVjaVlg016VluIT2wZpYYu5Fi/BH9sreOfK77IjdSUOM/rLOeQ4LAn0z3vN6 rc5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x19si10900481ejv.94.2019.11.11.23.02.16; Mon, 11 Nov 2019 23:02:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726896AbfKLHB1 (ORCPT + 99 others); Tue, 12 Nov 2019 02:01:27 -0500 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:47148 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbfKLHB1 (ORCPT ); Tue, 12 Nov 2019 02:01:27 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=tonylu@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0ThsYfQa_1573542084; Received: from localhost(mailfrom:tonylu@linux.alibaba.com fp:SMTPD_---0ThsYfQa_1573542084) by smtp.aliyun-inc.com(127.0.0.1); Tue, 12 Nov 2019 15:01:24 +0800 Date: Tue, 12 Nov 2019 15:01:23 +0800 From: Tony Lu To: Steven Rostedt Cc: mingo@redhat.com, sanagi.koki@jp.fujitsu.co, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu Desnoyers Subject: Re: [PATCH] net: add missing semicolon in net_dev_template Message-ID: <20191112070123.GA67139@TonyMac-Alibaba> Reply-To: Tony Lu References: <20191111141752.31655-1-tonylu@linux.alibaba.com> <20191111181228.49396467@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111181228.49396467@gandalf.local.home> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 06:12:28PM -0500, Steven Rostedt wrote: > On Mon, 11 Nov 2019 22:17:53 +0800 > Tony Lu wrote: > > > This patch adds missing semicolon in the end of net_dev_template. > > > > Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer") > > Signed-off-by: Tony Lu > > --- > > include/trace/events/net.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/trace/events/net.h b/include/trace/events/net.h > > index 2399073c3afc..3b28843652d2 100644 > > --- a/include/trace/events/net.h > > +++ b/include/trace/events/net.h > > @@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template, > > > > TP_printk("dev=%s skbaddr=%p len=%u", > > __get_str(name), __entry->skbaddr, __entry->len) > > -) > > +); > > Actually, we are thinking of making a sweeping patch set to remove all > these semicolons, as they are not needed, and would also allow more > flexible processing of the trace event macros. > > -- Steve Thanks for your reply, it's great to take actions to sweep them for a unified code style. I just found a different place in the code :-) Cheers Tony Lu > > > > > DEFINE_EVENT(net_dev_template, net_dev_queue, > >