Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Juri Lelli <juri.lelli@redhat.com>
To:     peterz@infradead.org, mingo@redhat.com, glenn@aurora.tech
Cc:     linux-kernel@vger.kernel.org, rostedt@goodmis.org,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        tglx@linutronix.de, luca.abeni@santannapisa.it,
        c.scordino@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
        bristot@redhat.com, juri.lelli@redhat.com
Subject: [PATCH 2/2] sched/deadline: Temporary copy static parameters to boosted non-DEADLINE entities
Date:   Tue, 12 Nov 2019 08:50:56 +0100
Message-Id: <20191112075056.19971-3-juri.lelli@redhat.com>
In-Reply-To: <20191112075056.19971-1-juri.lelli@redhat.com>
References: <20191112075056.19971-1-juri.lelli@redhat.com>
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Boosted entities (Priority Inheritance) use static DEADLINE parameters
of the top priority waiter. However, there might be cases where top
waiter could be a non-DEADLINE entity that is currently boosted by a
DEADLINE entity from a different lock chain (i.e., nested priority
chains involving entities of non-DEADLINE classes). In this case, top
waiter static DEADLINE parameters could null (initialized to 0 at
fork()) and replenish_dl_entity() would hit a BUG().

Fix this by temporarily copying static DEADLINE parameters of top
DEADLINE waiter (there must be at least one in the chain(s) for the
problem above to happen) into boosted entities. Parameters are reset
during deboost.

Reported-by: Glenn Elliott <glenn@aurora.tech>
Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
---
 kernel/sched/core.c     |  6 ++++--
 kernel/sched/deadline.c | 17 +++++++++++++++++
 kernel/sched/sched.h    |  1 +
 3 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 7880f4f64d0e..a3eb57cfcfb4 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4441,19 +4441,21 @@ void rt_mutex_setprio(struct task_struct *p, struct=
 task_struct *pi_task)
 =09=09if (!dl_prio(p->normal_prio) ||
 =09=09    (pi_task && dl_entity_preempt(&pi_task->dl, &p->dl))) {
 =09=09=09p->dl.dl_boosted =3D 1;
+=09=09=09if (!dl_prio(p->normal_prio))
+=09=09=09=09__dl_copy_static(p, pi_task);
 =09=09=09queue_flag |=3D ENQUEUE_REPLENISH;
 =09=09} else
 =09=09=09p->dl.dl_boosted =3D 0;
 =09=09p->sched_class =3D &dl_sched_class;
 =09} else if (rt_prio(prio)) {
 =09=09if (dl_prio(oldprio))
-=09=09=09p->dl.dl_boosted =3D 0;
+=09=09=09__dl_clear_params(p);
 =09=09if (oldprio < prio)
 =09=09=09queue_flag |=3D ENQUEUE_HEAD;
 =09=09p->sched_class =3D &rt_sched_class;
 =09} else {
 =09=09if (dl_prio(oldprio))
-=09=09=09p->dl.dl_boosted =3D 0;
+=09=09=09__dl_clear_params(p);
 =09=09if (rt_prio(oldprio))
 =09=09=09p->rt.timeout =3D 0;
 =09=09p->sched_class =3D &fair_sched_class;
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 951a7b44156f..a823391b245e 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2676,6 +2676,22 @@ bool __checkparam_dl(const struct sched_attr *attr)
 =09return true;
 }
=20
+/*
+ * This function clears the sched_dl_entity static params.
+ */
+void __dl_copy_static(struct task_struct *to, struct task_struct *from)
+{
+=09struct sched_dl_entity *to_se =3D &to->dl;
+=09struct sched_dl_entity *from_se =3D &from->dl;
+
+=09to_se->dl_runtime=09=3D from_se->dl_runtime;
+=09to_se->dl_deadline=09=3D from_se->dl_deadline;
+=09to_se->dl_period=09=3D from_se->dl_period;
+=09to_se->flags=09=09=3D from_se->flags;
+=09to_se->dl_bw=09=09=3D from_se->dl_bw;
+=09to_se->dl_density=09=3D from_se->dl_density;
+}
+
 /*
  * This function clears the sched_dl_entity static params.
  */
@@ -2690,6 +2706,7 @@ void __dl_clear_params(struct task_struct *p)
 =09dl_se->dl_bw=09=09=09=3D 0;
 =09dl_se->dl_density=09=09=3D 0;
=20
+=09dl_se->dl_boosted=09=09=3D 0;
 =09dl_se->dl_throttled=09=09=3D 0;
 =09dl_se->dl_yielded=09=09=3D 0;
 =09dl_se->dl_non_contending=09=3D 0;
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 0db2c1b3361e..92444306fff7 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -239,6 +239,7 @@ struct rt_bandwidth {
 =09unsigned int=09=09rt_period_active;
 };
=20
+void __dl_copy_static(struct task_struct *to, struct task_struct *from);
 void __dl_clear_params(struct task_struct *p);
=20
 /*
--=20
2.17.2