Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: sAK3/PzkJAq3rkHks7s/ZKnY85BNEnn7MT+pza3tUNKJx2U+mJfSRIHRigpokP5YB9F1jFkMfK
 mFui2aDYxeSpGAlAN2sE6caOZ4sLCc5chMETO9Itx6+F7aDofXIsuCBQ4BRcjwdrzJxzv14Hp+
 4S7r8gBKQC4dGmX/QBgqpUFVDt+nyQWpld0WalygmJngAUq2iRCw/plx4/ExHZ0tlvqJSlqncn
 PdTkAoYMLPPqXhsZtAwGqCqan7qB9ab0WSClM5tL7GdM2f8E1awAJpAH4F7ViH0bTjF0Xvjt65
 PKI=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "rnayak@codeaurora.org" <rnayak@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "saravanak@google.com" <saravanak@google.com>,
        "salyzyn@google.com" <salyzyn@google.com>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        Pedro Sousa <pedrom.sousa@synopsys.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Subhash Jadavani <subhashj@codeaurora.org>,
        Stanley Chu <stanley.chu@mediatek.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 3/5] scsi: ufs: Update VCCQ2 and VCCQ min voltage hard
 codes
Thread-Topic: [PATCH v1 3/5] scsi: ufs: Update VCCQ2 and VCCQ min voltage hard
 codes
Thread-Index: AQHVlgzHvpRg/BPDb0+DCvULsLcOEKeHMKbg
Date:   Tue, 12 Nov 2019 07:56:20 +0000
Message-ID: <MN2PR04MB6991D2D4444BB8E319CF916AFC770@MN2PR04MB6991.namprd04.prod.outlook.com>
References: <1573200932-384-1-git-send-email-cang@codeaurora.org>
 <1573200932-384-4-git-send-email-cang@codeaurora.org>
In-Reply-To: <1573200932-384-4-git-send-email-cang@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 71ae4d72-6de0-4a26-79d5-08d76745ce52
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2019 07:56:20.7134
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4LyTW9ywmDGIIp1p+T4+RgkJB2w3sH7LkKmooW2fWEuTQynqivFlrYIn6DUv+wuEPufv6hKjzLdPUdSASaXxZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB7022
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
>=20
> Per UFS 3.0 JEDEC standard, the VCCQ2 min voltage is 1.7v and the VCCQ mi=
n
> voltage is 1.14v, update their hard codes accordingly.
>=20
> Signed-off-by: Can Guo <cang@codeaurora.org>
AFAIK, Vccq2 is 1.7 - 1.95 in UFS2.1 as well.
Current constants applies to UFS1.1, as indicated in the original patch.
Vccq is <1.1 - 1.3> in UFS2.1,  and <1.14 - 1.26>, so need to update the ma=
x as well, and =20
make the assignments in ufshcd_populate_vreg depends on hba->ufs_version?

> ---
>  drivers/scsi/ufs/ufs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 385bac=
8..9df4f4d
> 100644
> --- a/drivers/scsi/ufs/ufs.h
> +++ b/drivers/scsi/ufs/ufs.h
> @@ -500,9 +500,9 @@ struct ufs_query_res {
>  #define UFS_VREG_VCC_MAX_UV       3600000 /* uV */
>  #define UFS_VREG_VCC_1P8_MIN_UV    1700000 /* uV */
>  #define UFS_VREG_VCC_1P8_MAX_UV    1950000 /* uV */
> -#define UFS_VREG_VCCQ_MIN_UV      1100000 /* uV */
> +#define UFS_VREG_VCCQ_MIN_UV      1140000 /* uV */
>  #define UFS_VREG_VCCQ_MAX_UV      1300000 /* uV */
> -#define UFS_VREG_VCCQ2_MIN_UV     1650000 /* uV */
> +#define UFS_VREG_VCCQ2_MIN_UV     1700000 /* uV */
>  #define UFS_VREG_VCCQ2_MAX_UV     1950000 /* uV */
>=20
>  /*
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum=
,
> a Linux Foundation Collaborative Project