Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Auger Eric <eric.auger@redhat.com>
Subject: Re: [PATCH v7 06/11] iommu/vt-d: Avoid duplicated code for PASID
 setup
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>,
        iommu@lists.linux-foundation.org,
        LKML <linux-kernel@vger.kernel.org>,
        Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>
Cc:     Yi Liu <yi.l.liu@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>,
        Raj Ashok <ashok.raj@intel.com>,
        Christoph Hellwig <hch@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Jonathan Cameron <jic23@kernel.org>
References: <1571946904-86776-1-git-send-email-jacob.jun.pan@linux.intel.com>
 <1571946904-86776-7-git-send-email-jacob.jun.pan@linux.intel.com>
Message-ID: <552c55f3-a8d6-10aa-5dbc-5b2c45ad90d0@redhat.com>
Date:   Tue, 12 Nov 2019 10:54:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <1571946904-86776-7-git-send-email-jacob.jun.pan@linux.intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jacob,

On 10/24/19 9:54 PM, Jacob Pan wrote:
> After each setup for PASID entry, related translation caches must be flus=
hed.
> We can combine duplicated code into one function which is less error pron=
e.
>=20
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
>  drivers/iommu/intel-pasid.c | 48 +++++++++++++++++----------------------=
------
>  1 file changed, 18 insertions(+), 30 deletions(-)
>=20
> diff --git a/drivers/iommu/intel-pasid.c b/drivers/iommu/intel-pasid.c
> index e79d680fe300..ffbd416ed3b8 100644
> --- a/drivers/iommu/intel-pasid.c
> +++ b/drivers/iommu/intel-pasid.c
> @@ -485,6 +485,21 @@ void intel_pasid_tear_down_entry(struct intel_iommu =
*iommu,
>  =09=09devtlb_invalidation_with_pasid(iommu, dev, pasid);
>  }
> =20
> +static void pasid_flush_caches(struct intel_iommu *iommu,
> +=09=09=09=09struct pasid_entry *pte,
> +=09=09=09=09int pasid, u16 did)
> +{
> +=09if (!ecap_coherent(iommu->ecap))
> +=09=09clflush_cache_range(pte, sizeof(*pte));
> +
> +=09if (cap_caching_mode(iommu->cap)) {
> +=09=09pasid_cache_invalidation_with_pasid(iommu, did, pasid);
> +=09=09iotlb_invalidation_with_pasid(iommu, did, pasid);
> +=09} else {
> +=09=09iommu_flush_write_buffer(iommu);
> +=09}
> +}
> +
>  /*
>   * Set up the scalable mode pasid table entry for first only
>   * translation type.
> @@ -530,16 +545,7 @@ int intel_pasid_setup_first_level(struct intel_iommu=
 *iommu,
>  =09/* Setup Present and PASID Granular Transfer Type: */
>  =09pasid_set_translation_type(pte, 1);
>  =09pasid_set_present(pte);
> -
> -=09if (!ecap_coherent(iommu->ecap))
> -=09=09clflush_cache_range(pte, sizeof(*pte));
> -
> -=09if (cap_caching_mode(iommu->cap)) {
> -=09=09pasid_cache_invalidation_with_pasid(iommu, did, pasid);
> -=09=09iotlb_invalidation_with_pasid(iommu, did, pasid);
> -=09} else {
> -=09=09iommu_flush_write_buffer(iommu);
> -=09}
> +=09pasid_flush_caches(iommu, pte, pasid, did);
> =20
>  =09return 0;
>  }
> @@ -603,16 +609,7 @@ int intel_pasid_setup_second_level(struct intel_iomm=
u *iommu,
>  =09 */
>  =09pasid_set_sre(pte);
>  =09pasid_set_present(pte);
> -
> -=09if (!ecap_coherent(iommu->ecap))
> -=09=09clflush_cache_range(pte, sizeof(*pte));
> -
> -=09if (cap_caching_mode(iommu->cap)) {
> -=09=09pasid_cache_invalidation_with_pasid(iommu, did, pasid);
> -=09=09iotlb_invalidation_with_pasid(iommu, did, pasid);
> -=09} else {
> -=09=09iommu_flush_write_buffer(iommu);
> -=09}
> +=09pasid_flush_caches(iommu, pte, pasid, did);
> =20
>  =09return 0;
>  }
> @@ -646,16 +643,7 @@ int intel_pasid_setup_pass_through(struct intel_iomm=
u *iommu,
>  =09 */
>  =09pasid_set_sre(pte);
>  =09pasid_set_present(pte);
> -
> -=09if (!ecap_coherent(iommu->ecap))
> -=09=09clflush_cache_range(pte, sizeof(*pte));
> -
> -=09if (cap_caching_mode(iommu->cap)) {
> -=09=09pasid_cache_invalidation_with_pasid(iommu, did, pasid);
> -=09=09iotlb_invalidation_with_pasid(iommu, did, pasid);
> -=09} else {
> -=09=09iommu_flush_write_buffer(iommu);
> -=09}
> +=09pasid_flush_caches(iommu, pte, pasid, did);
> =20
>  =09return 0;
>  }
>=20
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric