Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp360225ybc; Tue, 12 Nov 2019 02:37:56 -0800 (PST) X-Google-Smtp-Source: APXvYqzn/i+MCiEJFRqfniUJtGJ2BzZ9LBegXXH3TGrqn/K288VMsLhyMcf5n/ORdVvqxQN+tBgH X-Received: by 2002:aa7:c943:: with SMTP id h3mr31333053edt.207.1573555076021; Tue, 12 Nov 2019 02:37:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573555076; cv=none; d=google.com; s=arc-20160816; b=Xip8OvqhB0PQH6RLLCIjSZihseWcHiLoJdvhVe5zi5C2gp/ih0BF/Gc5/4z8+oG1F2 o+EWOt2aSCrDqCED06y8ksJh5xRtORpnpYIMm4hZ5XpVDwIU6e19JwG0bi0nBzgaKLry Eix7aK3IC3nBGRDUFhta8UDFSoCZrspaE1Sgljnl0o4NynFGkn5dSdhvX47nG/UlPUup 8VrMyaX+fx/yGsFHgAE9hYRC8m7D0lt3nQxO3xRDGghHIHVo2P/gfUNAthhM24SfG75E Drznvp5L9jRvizbbeuvJMLZY0MvqnTTvcgU2+w0DFKNvzupkq1BInmP/u9PlRgsTP56/ Gplw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:user-agent :in-reply-to:mime-version:references:message-id:subject:cc:to:from :date:dkim-signature; bh=xuxahvL3kg1EGPXS8GSuqJmgg7QGAaS4yIWjCAFx7Cc=; b=0PBiG0NqtrHMM6QDnRptVoRkUj/mZKm0v9wgrrOrcLcs27JoP1QOfvfQIlnNbusiI3 oozgbwVF29S7M9TmRtGt3irKh8sn2z11sMyYSWo9zwh7b2x4g6ZVe49Lm1/b2M8iYhwJ TeegMvJiHlyDduwihCHAvwb83DuuL+JuGObi+y1WcAqznDzBJp5rnqk7pXhjfLC6uSgX a5UQ1X7tH9xjbRXdtPVeCOrPyTGyZgCAIg9HNndCuiEopktxKxxTMh/EU3WWvJjFdKRy gdyo4uoYXAfB0gqEJmPTgt0DwgutjPoYScUG2FsLKJpkBULNpx4UUkdVUKtP0tc3hPNz RLZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="gGWk/HOL"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v20si15056765edc.69.2019.11.12.02.37.30; Tue, 12 Nov 2019 02:37:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="gGWk/HOL"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbfKLKeB (ORCPT + 99 others); Tue, 12 Nov 2019 05:34:01 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:59953 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725944AbfKLKeB (ORCPT ); Tue, 12 Nov 2019 05:34:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573554840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xuxahvL3kg1EGPXS8GSuqJmgg7QGAaS4yIWjCAFx7Cc=; b=gGWk/HOLVrIG7mGhg531uECVr1GYBsiEj2eJCj9pmLcxynOx2GR5x4xIb+Q7muzxXJSOng 5z/OCfRuRgnSA6Edfec4yJvFPU7/aBVXmcqUuTuptjaKKtcpMFg3HJOk2PsKzwwnC3OiFV Djiu2q6QIQgTw7qcEsFaPdequEsiqmg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-Y2ODGrCqMRC1KMNK5d05Fw-1; Tue, 12 Nov 2019 05:33:57 -0500 X-MC-Unique: Y2ODGrCqMRC1KMNK5d05Fw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15D4F1005500; Tue, 12 Nov 2019 10:33:56 +0000 (UTC) Received: from localhost (ovpn-116-203.ams2.redhat.com [10.36.116.203]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7512F171F9; Tue, 12 Nov 2019 10:33:55 +0000 (UTC) Date: Tue, 12 Nov 2019 10:33:54 +0000 From: Stefan Hajnoczi To: YueHaibing Cc: vgoyal@redhat.com, miklos@szeredi.hu, mszeredi@redhat.com, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] virtiofs: Fix old-style declaration Message-ID: <20191112103354.GF463128@stefanha-x1.localdomain> References: <20191111122359.43624-1-yuehaibing@huawei.com> MIME-Version: 1.0 In-Reply-To: <20191111122359.43624-1-yuehaibing@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eNMatiwYGLtwo1cJ" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eNMatiwYGLtwo1cJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 11, 2019 at 08:23:59PM +0800, YueHaibing wrote: > There expect the 'static' keyword to come first in a > declaration, and we get warnings like this with "make W=3D1": >=20 > fs/fuse/virtio_fs.c:687:1: warning: 'static' is not at beginning of decla= ration [-Wold-style-declaration] > fs/fuse/virtio_fs.c:692:1: warning: 'static' is not at beginning of decla= ration [-Wold-style-declaration] > fs/fuse/virtio_fs.c:1029:1: warning: 'static' is not at beginning of decl= aration [-Wold-style-declaration] >=20 > Signed-off-by: YueHaibing > --- > fs/fuse/virtio_fs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi --eNMatiwYGLtwo1cJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl3KipIACgkQnKSrs4Gr c8gdJwf+PUqmtiGDYcD4HiwZZWATLMxXmETqzmnRsTSpcZmilmmFYmNPT9MNuj7D oPRTSg2Buso6+GYt3HILA0QBHzltRPFpGHFKGFo87AMHUs8Hya8Kn/Ixtlzd2yzk uetQbToOHQ1BXjNmm8AVmXImi8hr6HVpNGfY08rcbiiw8f5pZeKEiXwLtWc/09Kl pkOLTnMrheeXEWt8eVMTUfGaUeEeylz3XRUdObm9Oq5hbN1DbERRV3WbNI55a96q n+X86cFuZP2dvI82+tS5bYl+DcGYkKWrM+kAKJWiwBO9vWTN/5M9UiJmdigSIFux i47j9PEBMtc87VtbuU9ytoi8EF51MA== =WtV3 -----END PGP SIGNATURE----- --eNMatiwYGLtwo1cJ--