Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 12 Nov 2019 15:45:50 +0100 (CET)
From:   Thomas Voegtle <tv@lio96.de>
To:     Jia-Ju Bai <baijiaju1990@gmail.com>,
        Joseph Qi <joseph.qi@linux.alibaba.com>,
        Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>
cc:     linux-kernel@vger.kernel.org
Subject: ocfs2: xattr problems with 5.4.0-rc7
Message-ID: <alpine.LSU.2.21.1911121355550.7620@er-systems.de>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-74181308-1838456657-1573569950=:7620"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---74181308-1838456657-1573569950=:7620
Content-Type: text/plain; format=flowed; charset=ISO-8859-7
Content-Transfer-Encoding: 8BIT


Hello,

with 5.4.0-rc7 and 4.9.200 we see the following errors with 
mkdir or touch on a ocfs2 mountpoint:

root@s2:/shared/ClusterShareDisk# mkdir dir
mkdir: cannot create directory ?dir?: Invalid argument

which produces this output:

root@s2:/shared/ClusterShareDisk# dmesg
[ 6918.815770] (mkdir,19461,0):ocfs2_xa_set:2242 ERROR: status = -22
[ 6918.815772] (mkdir,19461,0):ocfs2_mknod:408 ERROR: status = -22
[ 6918.816215] (mkdir,19461,0):ocfs2_mknod:486 ERROR: status = -22
[ 6918.816216] (mkdir,19461,0):ocfs2_mkdir:652 ERROR: status = -22

We got some ACLs:
$ getfacl /shared/ClusterShareDisk/
getfacl: Removing leading '/' from absolute path names
# file: shared/ClusterShareDisk/
# owner: root
# group: root
user::rwx
user:admin:rwx
group::rwx
mask::rwx
other::---
default:user::rwx
default:user:admin:rwx
default:group::rwx
default:mask::rwx
default:other::---

And of course it is mounted with user_xattr and acl option.

Reverting
commit 56e94ea132bb5c2c1d0b60a6aeb34dcb7d71a53d
Author: Jia-Ju Bai <baijiaju1990@gmail.com>
Date:   Sun Oct 6 17:57:50 2019 -0700

     fs: ocfs2: fix possible null-pointer dereferences in
ocfs2_xa_prepare_entry()

fixes the problem.

Greetings,


     Thomas
---74181308-1838456657-1573569950=:7620--