Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp663927ybc; Tue, 12 Nov 2019 07:24:02 -0800 (PST) X-Google-Smtp-Source: APXvYqxGt8vL+AeaCQ7VwCxTZSBUi7ub2v6GJgbgL561dF4KIGA/SJOGURqVkEMG/Cdxoot+UGfY X-Received: by 2002:aa7:d1c9:: with SMTP id g9mr33003702edp.162.1573572242495; Tue, 12 Nov 2019 07:24:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573572242; cv=none; d=google.com; s=arc-20160816; b=1C5NDc8aORrxNo/Kb9rXbTRXEcARUB0JyuFrNZ0PZ++qBaG4WTAlgWkFdZOksg1NHq ZNpoKijliBVSPoQ9cmuOGVjBauv8YtPYoL3m00mul1fVn5AuzBbBIbO3w2XDALANJS6y 6Sb/1sQkiSXw+/vUAX9FwRSn9rOrOwgKXfaddE6Xb7iiX3uh0fqJFwDBCz1PBBuLv9jB klIcaeBAGWW2XUeJlirhukAA1tmaogPBEy8CZmEULehhGmZWR2TFoyDB4ki+cDLDuYF1 XW5zJmtkKDuj7rdS5dFjiY1S9AaCB2TWXP3LlVYizH3SR9ecsats219v2l4O5qc4JAKx PXNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=BZANFq4xix4Xx203tkzaxuFkXxyuVqwVXr98xMHZnnc=; b=xKYgJorJ27Ha6EX8zmz8zG3NNludeyLZ8/tNSA85ET+QOy8libkmQ8YP6guHrZVK3f 06mhUPeGhcKN6ZzyL/Cq0l61n4FC6pGc8uoAfmLBy7Z1DFGBRPReEzv0MRqTUiOZgU2r 9JeEwcPTY1BuBYw3n9a0XIgDm4/JcCLciYQQkvIiptdHlFsNsegGddKrN/mvgtFoQPrQ CqqEGQThRyoltp7lisIDEO+P7tOAt6jIj6NbiS7GoRS53OwEC+C6fQPWDZf+RJWjHXMV Xxg1Syi9boO8O/giWfl9dMQWsWCM3q7akBrhtnrknLZY886f98YK9m7IzQZAjuHVufpb X3Qg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6si12554150edr.294.2019.11.12.07.23.37; Tue, 12 Nov 2019 07:24:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727513AbfKLPTX (ORCPT + 99 others); Tue, 12 Nov 2019 10:19:23 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:35285 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727401AbfKLPTW (ORCPT ); Tue, 12 Nov 2019 10:19:22 -0500 Received: by mail-pg1-f194.google.com with SMTP id q22so12078336pgk.2; Tue, 12 Nov 2019 07:19:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BZANFq4xix4Xx203tkzaxuFkXxyuVqwVXr98xMHZnnc=; b=YeSbv/o238TihuHuHsLnc7+bdmZy/QkzZyYaF031u7mpD8YNKqev8YWcQrJkAITcwU 3BVH3qOs7m0v1XmCSlfFJEMmvXcqPQ/ozYwOiRd3WrORKgOKBiKPR1WRHs6nEg/tT/N5 sHdex8rRaIaHt45wfzjAfxlJMTcLK9FO2UpECNI4J/epf1RCxgtiv0ZrhnbSRJzGfg1j a8XUnFliDvDxcNV3k9M3ElszJRYH2qlhzNv1Qzj0VPBMsK5q6YEeSuu+i3anYhitG/dV IDDxHdYdyy7bjk11+zSS894TYOnD55EAcCNEFOYSmjEMwD7WQPhOBUNobxBfBvu6rkuE 3JUA== X-Gm-Message-State: APjAAAV8fDTDhEvq4xpng9QJnpEQBk9WueqRMDmFiUDjemB5TrEx5d5j zP4ZSOA1y9Xn2J6vO4yAlHs= X-Received: by 2002:aa7:8a97:: with SMTP id a23mr37221666pfc.76.1573571960433; Tue, 12 Nov 2019 07:19:20 -0800 (PST) Received: from kozik-lap ([118.189.143.39]) by smtp.googlemail.com with ESMTPSA id 21sm25298308pfa.170.2019.11.12.07.19.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2019 07:19:19 -0800 (PST) Date: Tue, 12 Nov 2019 16:19:15 +0100 From: Krzysztof Kozlowski To: Marian Mihailescu Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org Subject: Re: [PATCH v4 2/2] ARM: dts: exynos5420: add mali dt node and enable mali on Odroid XU3/4 Message-ID: <20191112151915.GA15786@kozik-lap> References: <20191106225527.9121-1-mihailescu2m@gmail.com> <20191106225527.9121-2-mihailescu2m@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191106225527.9121-2-mihailescu2m@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 07, 2019 at 09:25:27AM +1030, Marian Mihailescu wrote: > Add device tree node for Mali GPU for Exynos 542x SoC. > GPU is disabled by default, and is enabled for each board after the > regulator is defined. Tested on Odroid-XU4. > > Changes since v3: > - fixed compatible to match bindings > > Changes since v2: > - separate patch for bindings > - fixed bindings typo > > Changes since v1: > - used generic node and label for GPU > - added bindings for compatible > - fixed irq indentation > - fixed interrupt-names to match bindings > - added cooling cells for future TMU connection > - used generic node and label for GPU opp table > - removed always-on from SoC GPU regulator > > Signed-off-by: Marian Mihailescu > --- > arch/arm/boot/dts/exynos5420.dtsi | 50 +++++++++++++++++++++++++++ > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 +++- Hi, Unfortunately this does not apply around exynos5422-odroid-core.dtsi. I think there were no changes to this file in current development cycle so I am surprised that there are conflicts. On what version were you basing your patch? Was it tested on latest kernel? The patches should be based usually on one of: 1. current-rc1 (v5.4-rc1) 2. latest-rc (v5.4-rc7) 3. maintainer's tree (my next/dt or for-next) 4. linux-next In all other cases the patch would need rebasing and re-testing. Best regards, Krzysztof