Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] drm: replace incorrect Compliance/Margin magic
 numbers with PCI_EXP_LNKCTL2 definitions
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        David Zhou <David1.Zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     Frederick Lawler <fred@fredlawl.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, Bjorn Helgaas <bhelgaas@google.com>
References: <20191111192932.36048-1-helgaas@kernel.org>
 <20191111192932.36048-2-helgaas@kernel.org>
From:   =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>
Message-ID: <6d86246e-504a-b762-aff8-0449dd6f3d31@daenzer.net>
Date:   Tue, 12 Nov 2019 17:45:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.1
MIME-Version: 1.0
In-Reply-To: <20191111192932.36048-2-helgaas@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-CA
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019-11-11 8:29 p.m., Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Add definitions for these PCIe Link Control 2 register fields:
> 
>   Enter Compliance
>   Transmit Margin
> 
> and use them in amdgpu and radeon.
> 
> NOTE: This is a functional change because "7 << 9" was apparently a typo.
> That mask included the high order bit of Transmit Margin, the Enter
> Modified Compliance bit, and the Compliance SOS bit, but I think what
> was intended was the 3-bit Transmit Margin field at bits 9:7.

Can you split out the functional change into a separate patch 1? That
could make things easier for anyone who bisects the functional change
for whatever reason.


-- 
Earthling Michel Dänzer               |               https://redhat.com
Libre software enthusiast             |             Mesa and X developer