Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 12 Nov 2019 17:48:25 +0100
Message-ID: <s5htv79niqu.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Henry Lin <henryl@nvidia.com>
Cc:     Jaroslav Kysela <perex@perex.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Allison Randal <allison@lohutok.net>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Richard Fontana <rfontana@redhat.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb-audio: not submit urb for stopped endpoint
In-Reply-To: <MN2PR12MB33899EA399AF4338AA882F1DAC770@MN2PR12MB3389.namprd12.prod.outlook.com>
References: <20191112065108.7766-1-henryl@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 12 Nov 2019 17:41:42 +0100,
Henry Lin wrote:
> 
> > Ah, I see.  Then you don't have to write up the full stack trace like
> > the above.  It's confusing as if it were some kernel Oops or WARNING.
> Got it. Should I post another patch set here for removing these confusing description in commit message? Or you can help to remove them before merging?

Please resubmit after rephrasing the patch description.

> > BTW, with your patch, is the error in the first line ("timeout: still
> > 1 active urbs on EP #1") also fixed?
> Yes, "timeout: still 1 active urbs on EP #1" will be fixed as well.

OK, then this should be mentioned in the patch description.
Actually the patch fixes this kind of error (the stall at the
concurrent stream stop).


thanks,

Takashi