Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp816248ybc; Tue, 12 Nov 2019 09:36:15 -0800 (PST) X-Google-Smtp-Source: APXvYqyAfDiqEV8FvcbdAs26P32iXVecc6PoMjuOya7ASsK1OVndCP0F7hF4u6DYkIx2TJWqMtq1 X-Received: by 2002:a05:6402:57:: with SMTP id f23mr33930910edu.257.1573580175664; Tue, 12 Nov 2019 09:36:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573580175; cv=none; d=google.com; s=arc-20160816; b=Zv+OGnCPL252GQppaZeMMDOfsmktO/cz8jm0Galxzni+Aefqgv4FYnzCkX84lhGNEd s8/leN8TNH92aoyG9IZPLrbDWNdTPN6Y48A2JHCHjYu3Bsh2RKBA8LxRXCkFnI1Z4L+2 vI59St94uyKIfbcElvLMVgYbVbyUZE1oVXRnumaHshB3eJ6K9CEoQo4zy6VEpWt0P/UG Bw0212+5ID8qo7iGSy0dI1dmZl3S5eWcHqzDAIrsfFloVWPTT8rhmN1RFhTN0yidH2xC 2alx+4pd277aMB09BsrC/6vYoVLq/WxuCmNpwIg7iz1cVLEnkdaJ/t0qMXPy/Wln9S+r lh9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IXhmdT13sL8Epqlzc1Qx/9CtQ8xUbDRZ58OqVluXZCQ=; b=LBb7jWa22C/P+648HoQt0f0zXCMXoqW12QT9chXAQiFRDQhlav59QEn3wtgW7lTW8c kEfJSHyg4C4vqB+O/v/CyZ6psaGocXoofVAzxqZbRCInCifpV5pk9OTc7haWGtxKpegP fi5UjWAeNYEJ88pUCuHFavMnsbEFjJgfFLCZaUEGaFSXAnczacQDVJEsYvEkim57TaOh L9io9v2LL2J5hx6Wx8Bd8nVb7Wy8Uq6Xj9LYtIFeD3wRo0UMnu0/G+see0eJJOuUL5LL v3HH6oD9KVEVA7sJbCagRbQgkN4XNmJunPybBrgO96NLd0+tlIvcy+YwX8h21x191EYA FOdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="mceh4Ur/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si412322eja.89.2019.11.12.09.35.50; Tue, 12 Nov 2019 09:36:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="mceh4Ur/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727279AbfKLRfQ (ORCPT + 99 others); Tue, 12 Nov 2019 12:35:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:59574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726718AbfKLRfQ (ORCPT ); Tue, 12 Nov 2019 12:35:16 -0500 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7CB18214E0; Tue, 12 Nov 2019 17:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573580115; bh=+4EzQSM/k1VOif0/E/W/Xzv0GPRgNyMJHG5BQwoLXVU=; h=From:To:Cc:Subject:Date:From; b=mceh4Ur/VUEpqNhsdVlcNrzbKQFA3I3i+cQuPTI008T6RWy3FC2d15H05pRpKd3BW jWQWNqALKkTJyK/FbmzWRaDCohiyixeo0KKI1QAU4toEhNq++YbHzZVlVjoHQeVyeT 1bmiyZkFCmbQ0PnoDeuOgGmZUQ6HFRsRubGkHM00= From: Bjorn Helgaas To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Zhou , David Airlie , Daniel Vetter Cc: Frederick Lawler , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ilia Mirkin , linux-pci@vger.kernel.org, =?UTF-8?q?Michel=20D=C3=A4nzer?= , Bjorn Helgaas Subject: [PATCH V3 0/3] drm: replace magic numbers Date: Tue, 12 Nov 2019 11:35:00 -0600 Message-Id: <20191112173503.176611-1-helgaas@kernel.org> X-Mailer: git-send-email 2.24.0.rc1.363.gb1bccd3e3d-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas amdgpu and radeon do a bit of mucking with the PCIe Link Control 2 register, some of it using hard-coded magic numbers. The idea here is to replace those with #defines. Since v2: - Fix a gpu_cfg2 case in amdgpu/si.c that I had missed - Separate out the functional changes for better bisection (thanks, Michel!) - Add #defines in a patch by themselves (so a GPU revert wouldn't break other potential users) - Squash all the magic number -> #define changes into one patch Since v1: - Add my signed-off-by and Alex's reviewed-by. Bjorn Helgaas (3): PCI: Add #defines for Enter Compliance, Transmit Margin drm: correct Transmit Margin masks drm: replace numbers with PCI_EXP_LNKCTL2 definitions drivers/gpu/drm/amd/amdgpu/cik.c | 22 ++++++++++++++-------- drivers/gpu/drm/amd/amdgpu/si.c | 22 ++++++++++++++-------- drivers/gpu/drm/radeon/cik.c | 22 ++++++++++++++-------- drivers/gpu/drm/radeon/si.c | 22 ++++++++++++++-------- include/uapi/linux/pci_regs.h | 2 ++ 5 files changed, 58 insertions(+), 32 deletions(-) -- 2.24.0.rc1.363.gb1bccd3e3d-goog