Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 12 Nov 2019 14:52:36 -0500
From:   Jerome Glisse <jglisse@redhat.com>
To:     Ralph Campbell <rcampbell@nvidia.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/debug: __dump_page() prints an extra line
Message-ID: <20191112195236.GB31272@redhat.com>
References: <20191111225559.19657-1-rcampbell@nvidia.com>
MIME-Version: 1.0
In-Reply-To: <20191111225559.19657-1-rcampbell@nvidia.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 11, 2019 at 02:55:59PM -0800, Ralph Campbell wrote:
> When dumping struct page information, __dump_page() prints the page type
> with a trailing blank followed by the page flags on a separate line:
>=20
> anon
> flags: 0x100000000090034(uptodate|lru|active|head|swapbacked)
>=20
> Fix this by using pr_cont() instead of pr_warn() to get a single line:
>=20
> anon flags: 0x100000000090034(uptodate|lru|active|head|swapbacked)
>=20
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>

Reviewed-by: J=E9r=F4me Glisse <jglisse@redhat.com>

> ---
>=20
> v1 -> v2:
> Oops, fix the subject line.
>=20
>  mm/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/mm/debug.c b/mm/debug.c
> index 8345bb6e4769..752c78721ea0 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -87,7 +87,7 @@ void __dump_page(struct page *page, const char *reason)
>  =09}
>  =09BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) !=3D __NR_PAGEFLAGS + 1);
> =20
> -=09pr_warn("flags: %#lx(%pGp)\n", page->flags, &page->flags);
> +=09pr_cont("flags: %#lx(%pGp)\n", page->flags, &page->flags);
> =20
>  hex_only:
>  =09print_hex_dump(KERN_WARNING, "raw: ", DUMP_PREFIX_NONE, 32,
> --=20
> 2.20.1
>=20
>=20