Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 12 Nov 2019 14:55:47 -0500
From:   Jerome Glisse <jglisse@redhat.com>
To:     Ralph Campbell <rcampbell@nvidia.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/debug: __dump_page() prints an extra line
Message-ID: <20191112195547.GC31272@redhat.com>
References: <20191112012608.16926-1-rcampbell@nvidia.com>
MIME-Version: 1.0
In-Reply-To: <20191112012608.16926-1-rcampbell@nvidia.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 11, 2019 at 05:26:08PM -0800, Ralph Campbell wrote:
> When dumping struct page information, __dump_page() prints the page type
> with a trailing blank followed by the page flags on a separate line:
>=20
> anon
> flags: 0x100000000090034(uptodate|lru|active|head|swapbacked)
>=20
> It looks like the intent was to use pr_cont() for printing "flags:"
> but pr_cont() usage is discouraged so fix this by extending the format
> to include the flags into a single line:
>=20
> anon flags: 0x100000000090034(uptodate|lru|active|head|swapbacked)
>=20
> If the page is file backed, the name might be long so use two lines:
>=20
> shmem_aops name:"dev/zero"
> flags: 0x10000000008000c(uptodate|dirty|swapbacked)
>=20
> Eliminate pr_conf() usage as well for appending compound_mapcount.
>=20
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>

Would be nice to have a changed since v1 v2 ... i was reading my
inbox in order and i saw Andrew reply after seeing the v2 ... so
where we at here ?

> ---
>  mm/debug.c | 27 +++++++++++++++------------
>  1 file changed, 15 insertions(+), 12 deletions(-)
>=20
> diff --git a/mm/debug.c b/mm/debug.c
> index 8345bb6e4769..772d4cf0691f 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -67,28 +67,31 @@ void __dump_page(struct page *page, const char *reaso=
n)
>  =09 */
>  =09mapcount =3D PageSlab(page) ? 0 : page_mapcount(page);
> =20
> -=09pr_warn("page:%px refcount:%d mapcount:%d mapping:%px index:%#lx",
> -=09=09  page, page_ref_count(page), mapcount,
> -=09=09  page->mapping, page_to_pgoff(page));
>  =09if (PageCompound(page))
> -=09=09pr_cont(" compound_mapcount: %d", compound_mapcount(page));
> -=09pr_cont("\n");
> +=09=09pr_warn("page:%px refcount:%d mapcount:%d mapping:%px "
> +=09=09=09"index:%#lx compound_mapcount: %d\n",
> +=09=09=09page, page_ref_count(page), mapcount,
> +=09=09=09page->mapping, page_to_pgoff(page),
> +=09=09=09compound_mapcount(page));
> +=09else
> +=09=09pr_warn("page:%px refcount:%d mapcount:%d mapping:%px index:%#lx\n=
",
> +=09=09=09page, page_ref_count(page), mapcount,
> +=09=09=09page->mapping, page_to_pgoff(page));
>  =09if (PageAnon(page))
> -=09=09pr_warn("anon ");
> +=09=09pr_warn("anon flags: %#lx(%pGp)\n", page->flags, &page->flags);
>  =09else if (PageKsm(page))
> -=09=09pr_warn("ksm ");
> +=09=09pr_warn("ksm flags: %#lx(%pGp)\n", page->flags, &page->flags);
>  =09else if (mapping) {
> -=09=09pr_warn("%ps ", mapping->a_ops);
>  =09=09if (mapping->host && mapping->host->i_dentry.first) {
>  =09=09=09struct dentry *dentry;
>  =09=09=09dentry =3D container_of(mapping->host->i_dentry.first, struct d=
entry, d_u.d_alias);
> -=09=09=09pr_warn("name:\"%pd\" ", dentry);
> -=09=09}
> +=09=09=09pr_warn("%ps name:\"%pd\"\n", mapping->a_ops, dentry);
> +=09=09} else
> +=09=09=09pr_warn("%ps\n", mapping->a_ops);
> +=09=09pr_warn("flags: %#lx(%pGp)\n", page->flags, &page->flags);
>  =09}
>  =09BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) !=3D __NR_PAGEFLAGS + 1);
> =20
> -=09pr_warn("flags: %#lx(%pGp)\n", page->flags, &page->flags);
> -
>  hex_only:
>  =09print_hex_dump(KERN_WARNING, "raw: ", DUMP_PREFIX_NONE, 32,
>  =09=09=09sizeof(unsigned long), page,
> --=20
> 2.20.1
>=20
>=20