Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Nov 2019 15:14:35 -0800 (PST)
Message-Id: <20191111.151435.931035548376130641.davem@davemloft.net>
To:     clabbe@baylibre.com
Cc:     alexandre.torgue@st.com, joabreu@synopsys.com, mripard@kernel.org,
        peppe.cavallaro@st.com, wens@csie.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-sunxi@googlegroups.com,
        stable@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: dwmac-sun8i: Use the correct function
 in exit path
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1573385448-30282-1-git-send-email-clabbe@baylibre.com>
References: <1573385448-30282-1-git-send-email-clabbe@baylibre.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Corentin Labbe <clabbe@baylibre.com>
Date: Sun, 10 Nov 2019 11:30:48 +0000

> When PHY is not powered, the probe function fail and some resource are
> still unallocated.
> Furthermore some BUG happens:
> dwmac-sun8i 5020000.ethernet: EMAC reset timeout
> ------------[ cut here ]------------
> kernel BUG at /linux-next/net/core/dev.c:9844!
> 
> So let's use the right function (stmmac_pltfr_remove) in the error path.
> 
> Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
> Cc: <stable@vger.kernel.org> # v4.15+
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Applied.