Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp983994ybc; Tue, 12 Nov 2019 12:16:40 -0800 (PST) X-Google-Smtp-Source: APXvYqzFW6wH8o9Ei/Fn35yS4uBALNduLvZKG0ZFW7FtnyJZn0gKz1NQUzTTYPESRK5KSjrYIuRF X-Received: by 2002:a17:906:5211:: with SMTP id g17mr1008413ejm.60.1573589800639; Tue, 12 Nov 2019 12:16:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573589800; cv=none; d=google.com; s=arc-20160816; b=dsJwTWs81holCzJRKl7bwuDM8b1mBBp695LBTyrEpWJvcvZIEDiQClKiO7/jlqKgi5 2aq3hUyhBhGdn+kMppruA2PxfQHUuWjkZv2hj8WPc5o7DgL2DOPINFjtQfPlQRE8hWDV THe3y9182ANYxfEkQarjAwEDWqkhMH6ic/HKslpb0Wk4OAzINuL9ArPiBbLexCTr3cW6 pGzVvVasR2XKkLLPW0RgS5vxePoRLtDcfw0/tGKKH8EpK3Uk+4RaGIfuUnBDJE1jE2Xw F9l7aCnWMb61Ys6UIBmCYuDrJc/x7oG4nm2NkuDo6Or7WV0m8CY0ZhlaX/vDz1+z8anB /kbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=S0GjGgj7XPhOFzrLImvQwZZ4g979nvvzusTYzAZRnec=; b=xpe5iEvj7J87chNk46ruikP8NacxqTgL5B8g2SLjxoB3kb2ue1VHDGJL5AUD/YcYHC L3scDDQJI4kyFXMCvkI0JM/F0cAB4bDLC0SQ7aUQB33ZM06uh50mDNCcI8V7gpAwrarJ 4oYdiUTRQ60E6XRlzOt7jLYhvpO/SsyLn+k/6PrU7mkmoyiCag2jln+Uv0JyxI2ve7cn xMPX2+kFJY1KamC0Dgb2uWgTZTb8YoPszZ+qiAHRp2Mp0pAsYgDG8ra1SAHUQjg+2f8I VpriHNtdzG52RCrodSPNmnaaDipWzOXdJTGI07AyKV/5SF5pB0J8W4Xhze9VTi83Qw/+ 4AKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ce9si739800ejb.213.2019.11.12.12.16.15; Tue, 12 Nov 2019 12:16:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727199AbfKLUMb (ORCPT + 99 others); Tue, 12 Nov 2019 15:12:31 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48928 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbfKLUMI (ORCPT ); Tue, 12 Nov 2019 15:12:08 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B6150154D23BE; Tue, 12 Nov 2019 12:12:07 -0800 (PST) Date: Mon, 11 Nov 2019 14:41:43 -0800 (PST) Message-Id: <20191111.144143.1922066976980512193.davem@davemloft.net> To: mschiffer@universe-factory.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: Re: [PATCH net-next 2/2] bridge: implement get_link_ksettings ethtool method From: David Miller In-Reply-To: <8e414e98928aba7f11ea997498fb18af05434f5f.1573321597.git.mschiffer@universe-factory.net> References: <8e414e98928aba7f11ea997498fb18af05434f5f.1573321597.git.mschiffer@universe-factory.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Nov 2019 12:12:07 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthias Schiffer Date: Sat, 9 Nov 2019 18:54:14 +0100 > + if (cmd->base.speed == (__u32)SPEED_UNKNOWN || > + cmd->base.speed < ecmd.base.speed) { > + cmd->base.speed = ecmd.base.speed; > + } Curly braces are unnecessary for single line statements, so please remove.