Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1485351ybc; Tue, 12 Nov 2019 22:40:35 -0800 (PST) X-Google-Smtp-Source: APXvYqz0JzrfZ6uAdEmX/GJOZWaY/7KdThyRgRfK+dUXmcxE4u01NupzGydUV/UwTj6D93XONHLr X-Received: by 2002:a17:906:3ec8:: with SMTP id d8mr1235191ejj.55.1573627235009; Tue, 12 Nov 2019 22:40:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573627235; cv=none; d=google.com; s=arc-20160816; b=MWTNN+i2jpvxQAve8/q6NuHUvuHXkFOzBXDWxr59QYXM14EsTALdSrHABz00iy46n8 Ockm0Wh+XTzPgIgq7d6QT3GZ6EFmyjWOr8ka9nwn21bKYUWC+m+IBa+9Fm4yk3YoY1pr 3wEW4FMRknS7a9c8vi+FGEuI5wFEjguLqRX72nQpDHeMIHAhSrqLzO18F+rj6xk4Ef7S keqIBJ8elLcOS4PALpyDBfB7lvPF6fW6bvXCFhveHc14dM0egl8pGQYqCAhu+Qzn2nhi 3AsViodW1EhvsC++14Hp+t+bhqLa49tacoL8c5y1bCaNmu4aZMRBcNunAQq1iVSPRO+v clmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=yXikumjy+JcdsMguaz7purxBZ6df2n0Pz7z+WJDAYNc=; b=FArs2kfD6H98mKsPHCdhxGLEjq6pWtc9qqKWvNV+YxmSwW7kCrMjYEUEdxUieCPRwy 2IHBBLga3PfzrK30xxS/0hbyHQ1ib6jAtG2EB0WN80eB1RHpeePRiR8Fqff5z4AG6mew aO31ulGEsKQuCrVN8tXdHJ0sXiXQxwkcuicr2j+iUhM8VVJ9tJeWyPjpbYMrz82Uh5P7 Hid+xCjX2aaKIeFVa6XgY9RQeb/oa5SUWcoB2pGRP2HPIDirLgukw39uC7htoE48GoAm GN8FVpnAY4QJAhkfF0h+rO4diYiBc7qVJB4dq5ohEe9YnrFxtkd95YNOpuDE8dUD9zCQ GLsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=P4LjTSfE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si560648ejk.336.2019.11.12.22.40.10; Tue, 12 Nov 2019 22:40:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=P4LjTSfE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727132AbfKMGic (ORCPT + 99 others); Wed, 13 Nov 2019 01:38:32 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43387 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbfKMGic (ORCPT ); Wed, 13 Nov 2019 01:38:32 -0500 Received: by mail-pg1-f195.google.com with SMTP id l24so716232pgh.10 for ; Tue, 12 Nov 2019 22:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yXikumjy+JcdsMguaz7purxBZ6df2n0Pz7z+WJDAYNc=; b=P4LjTSfEMQHW293vKti2IkTAd0W1xhJ+X+xNzCRKIoBrvjSkWTETRgGVIn3naIzkO4 awJ4PynJ4LBaOuqbL8WcWi7FrkYtgm40DkT81Q5u7IwerC58SO/R1MOulDzw+bxrGCJZ 63JgQ18IdCrfEHnBvIPjW697A9d3LgzR0DxuTCMAir0bzBl2ODkybx14IRNwKb8QlIZ2 j+0nnm8gXfNDl726+IFSGX8rynqlvGFCrLgXJtz0tNjrbedEZEW11X7KFJKccbZyNe0L c25ZUldKo/ZIRF5jhmNZNFAR40tloz432S5uEUeiHmugoctaL09i1z+yD8Uo1org2IHo LmIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yXikumjy+JcdsMguaz7purxBZ6df2n0Pz7z+WJDAYNc=; b=nxaSXdXtQ2Q2fw8yaCVfqXlRdPPetgYY5PtHtGCxuIETzXv7BxjwvEZB6ifm6QQ7IJ qQFxIH0GyRi91qmLf3Iabu/rtYbJvBl2kEft2wlvpNsCVCOQt/2Td4+wRJIzIPnLxV8e guVbhN9QkKtYQNgEAk9zvrSGbxUKfvuy5CZF8hqq3L4RFW6A5UNhCqrNUwgXtqcoupXP GomZLDNoTe9cv3kdaxedAIbggjyApynbwn2kUEL5HSZOSbQYSLY1rcFi323xhb4Wrd+D m3kU60kwGTksteI+/LYklbwzdCFYP+/AYoP08vkECzuNiVT8SAs7+uDHde+guIsiZJKa GRGg== X-Gm-Message-State: APjAAAXBwMcoU0UWmctfCHjVV85opde8oS47ZY2XUiFTZ51Ez/nl/DHq tRQbrv4DMPkRb2uaVxfhnH69XO05vYs= X-Received: by 2002:a65:49c7:: with SMTP id t7mr1835081pgs.431.1573627111642; Tue, 12 Nov 2019 22:38:31 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id n23sm1054844pff.137.2019.11.12.22.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 22:38:31 -0800 (PST) From: Chuhong Yuan Cc: Benson Leung , Enric Balletbo i Serra , linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove Date: Wed, 13 Nov 2019 14:38:21 +0800 Message-Id: <20191113063821.8896-1-hslester96@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver forgets to destroy workqueue in remove. Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- drivers/platform/chrome/cros_usbpd_logger.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c index 2430e8b82810..374cdd1e868a 100644 --- a/drivers/platform/chrome/cros_usbpd_logger.c +++ b/drivers/platform/chrome/cros_usbpd_logger.c @@ -224,6 +224,7 @@ static int cros_usbpd_logger_remove(struct platform_device *pd) struct logger_data *logger = platform_get_drvdata(pd); cancel_delayed_work_sync(&logger->log_work); + destroy_workqueue(logger->log_workqueue); return 0; } -- 2.23.0