Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1487110ybc; Tue, 12 Nov 2019 22:43:08 -0800 (PST) X-Google-Smtp-Source: APXvYqwaMUBjt5JInK7EUdideG4597GkpuJJ/n852Bo52/QTV7hwq3NbQJeL1kJm86xWB7YlF3y6 X-Received: by 2002:a17:906:8307:: with SMTP id j7mr1170431ejx.171.1573627388057; Tue, 12 Nov 2019 22:43:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573627388; cv=none; d=google.com; s=arc-20160816; b=tHxkseL+5oYdrRJ2HC/mGzeszha9COwn9Aei1DkD/TWd4toc2ei64Ne9/u3+qFFsEU sG5flDBrX2cf5hh7pyxv6hHki+kd+ShzHdNAA37Fs1G213LWELn+x0bDqvQYMTKtSdpY hTfIDv2q+0zDCMKzQ2mQiSNck/YZb1hWidqAQ97MDriukMWtGelStXpgvNPuOOmt3pur 8A4Nk2UWtCAWYFHxRTiBc+iun8N4L8qcRBO1QJ3wyPIhs9UqZtvTtAIddI7uqhbtH9a4 wKJy8HHPJ1v3lYISv5JF2zqY8fb+VeCw6+382bYQRezFY8NJsSqGls5dHI2Dqhx9Wcfy HuKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=tB9AYDSxsTqJPT8wcekDci2iu2m/7gu/sjqNAn149fQ=; b=YQWOWgAk+8nq72w1l3CDDMwEYm9m1WigRF/zuP5oF7b8mnmSlGt7N6aNRVUkGGQCUf NB3Mh3sodB8QrYoc+748+vHKHNdIeWXjV2xb4ye9SEk1w1ZfQPiJ7Sm+Cuv/buJBOF5b Ak8MzPAM0RQ3pl/uI3M7qTztjkP1yG0f/IzFj1swsJW5VmuQeEdBG/SNFGTYdfFXequ+ rbdeCWtF2JxLNC+rcNY4TQyjLeoqEEpSkOJb7OjzsFcc5ozRYYKu5n9E2l3fEW0QtsRV 54WfliLLPAI7e2d55uSVD4dBsztryj1pxy0ublmpBOqSm5OXazcynpd012m0KtTSpTwn aj+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="C/0dR930"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8si813160edi.445.2019.11.12.22.42.43; Tue, 12 Nov 2019 22:43:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="C/0dR930"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727151AbfKMGjA (ORCPT + 99 others); Wed, 13 Nov 2019 01:39:00 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38173 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbfKMGjA (ORCPT ); Wed, 13 Nov 2019 01:39:00 -0500 Received: by mail-pg1-f195.google.com with SMTP id 15so736484pgh.5; Tue, 12 Nov 2019 22:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tB9AYDSxsTqJPT8wcekDci2iu2m/7gu/sjqNAn149fQ=; b=C/0dR930MA1kbc8j6GjGGV6Ufam4ZkttBfD6R4Eajv5UCZ3Kw7cyAmA5Og8ODHCmsI IR7sMdsvrc8zQNYaOOTWF3U4NHZODC3pwHWm3UjoBF1LiMvWLSihuI3podvLQsBqXeeC tWj4icZZ9pjdw/LROvjaNVfyZmysruFhv711j3OPSglzMUdhhYJVzvLywXaZRynJJX5F SwY3mq/ZASlY745JENj7y2O00afbNjQuC7JAxQPVHNlRWBnYrnJr4k3GTMznAisTLTyX EDmfbgxeyuUruw+aXGr1NKv01afC6NWTyq0yynmGHm5X7j+9UgMcr3s6deoDw5kVeJLV s5wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tB9AYDSxsTqJPT8wcekDci2iu2m/7gu/sjqNAn149fQ=; b=czSQnSMu0ZUNjx1ycMaVZNGRVRsGwYIrayHLbFs6k5DZ+4/9xxmbZ3nDv73vF6U3C+ k756WySViBKvmh/84ZXktSDK6MgLLwBo8Mecebb+Q06Pvcz3rAzT8rGyCNcHsxtNe19+ 7b4q5o+aU1tCS7QpjCqfKQWNao6d/1ut9pGB5Kk2gS1uHpXBv8Os6QIR2NrXfaaINbM1 Damm1/JZjId6C3Hys9ZJK/I/s0dFESNmoz8TtqR0NUFVroMUzcx7y27LkdZkLdMg/wHs DRuoZH1Qj8VXgSJ1UEjsyyXFWjUKaXMvyR+5mVupatxofC3si9FJFzj+YZD6csqrYq2G 27wA== X-Gm-Message-State: APjAAAWTOZSi6Ca2XA6j6cRDkhOrQ9RjtJIy8DoFiTFXX4Ka44CS0irb S2FNy1ZopvNi2Z5GfpRBUp8= X-Received: by 2002:a62:ab17:: with SMTP id p23mr2418010pff.116.1573627139775; Tue, 12 Nov 2019 22:38:59 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id y138sm1310868pfb.174.2019.11.12.22.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 22:38:59 -0800 (PST) From: Chuhong Yuan Cc: Joshua Morris , Philip Kelleher , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] rsxx: add missed destroy_workqueue calls in remove Date: Wed, 13 Nov 2019 14:38:47 +0800 Message-Id: <20191113063847.8955-1-hslester96@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver misses calling destroy_workqueue in remove like what is done when probe fails. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan --- drivers/block/rsxx/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 76b73ddf8fd7..10f6368117d8 100644 --- a/drivers/block/rsxx/core.c +++ b/drivers/block/rsxx/core.c @@ -1000,8 +1000,10 @@ static void rsxx_pci_remove(struct pci_dev *dev) cancel_work_sync(&card->event_work); + destroy_workqueue(card->event_wq); rsxx_destroy_dev(card); rsxx_dma_destroy(card); + destroy_workqueue(card->creg_ctrl.creg_wq); spin_lock_irqsave(&card->irq_lock, flags); rsxx_disable_ier_and_isr(card, CR_INTR_ALL); -- 2.23.0